From: Junio C Hamano <gitster@pobox•com>
To: Patryk Obara <patryk.obara@gmail•com>
Cc: git@vger•kernel.org, sandals@crustytoothpaste•net,
Stefan Beller <sbeller@google•com>,
Jonathan Nieder <jrnieder@gmail•com>
Subject: Re: [PATCH v2 4/4] commit: rewrite read_graft_line
Date: Thu, 17 Aug 2017 14:20:46 -0700 [thread overview]
Message-ID: <xmqq378pgac1.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <b63b2148b7d79ebe5c57b876c7077a9ac42d2869.1502905085.git.patryk.obara@gmail.com> (Patryk Obara's message of "Wed, 16 Aug 2017 19:58:25 +0200")
Patryk Obara <patryk.obara@gmail•com> writes:
> The previous implementation of read_graft_line used calculations based
> on GIT_SHA1_RAWSZ and GIT_SHA1_HEXSZ to determine the number of commit
> ids in a single graft line. New implementation does not depend on these
> constants, so it adapts to any object_id buffer size.
>
> To make this possible, FLEX_ARRAY of object_id in struct was replaced
> by an oid_array.
There is a leap in logic between the two paragraphs. Your use of
parse_oid_hex() is good. But I do not think moving the array body
to outside commit_graft structure and forcing it to be separately
allocated is necessary or beneficial. When we got a single line, we
know how many fake parents a child described by that graft line has,
and you can still use of FLEX_ARRAY to avoid separate allocation
and need for separate freeing of it.
next prev parent reply other threads:[~2017-08-17 21:20 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 11:49 [PATCH 0/5] Modernize read_graft_line implementation Patryk Obara
2017-08-15 11:49 ` [PATCH 1/5] cache: extend object_id size to sha3-256 Patryk Obara
2017-08-15 11:49 ` [PATCH 2/5] sha1_file: fix hardcoded size in null_sha1 Patryk Obara
2017-08-15 18:23 ` Junio C Hamano
2017-08-15 18:29 ` Stefan Beller
2017-08-15 19:02 ` Junio C Hamano
2017-08-16 12:11 ` Patryk Obara
2017-08-16 19:32 ` Junio C Hamano
2017-08-15 11:49 ` [PATCH 3/5] commit: replace the raw buffer with strbuf in read_graft_line Patryk Obara
2017-08-15 17:02 ` Stefan Beller
2017-08-16 12:24 ` Patryk Obara
2017-08-16 22:59 ` brian m. carlson
2017-08-17 5:55 ` Jeff King
2017-08-17 21:17 ` Junio C Hamano
2017-08-17 21:38 ` Patryk Obara
2017-08-15 18:25 ` Junio C Hamano
2017-08-15 11:49 ` [PATCH 4/5] commit: implement free_commit_graft Patryk Obara
2017-08-15 17:04 ` Stefan Beller
2017-08-15 18:26 ` Junio C Hamano
2017-08-16 12:28 ` Patryk Obara
2017-08-15 11:49 ` [PATCH 5/5] commit: rewrite read_graft_line Patryk Obara
2017-08-15 17:11 ` Stefan Beller
2017-08-15 18:30 ` Junio C Hamano
2017-08-16 13:07 ` Patryk Obara
2017-08-16 19:39 ` Junio C Hamano
2017-08-15 17:19 ` [PATCH 0/5] Modernize read_graft_line implementation Stefan Beller
2017-08-16 17:58 ` [PATCH v2 0/4] " Patryk Obara
2017-08-16 17:58 ` [PATCH v2 1/4] sha1_file: fix hardcoded size in null_sha1 Patryk Obara
2017-08-16 19:46 ` Junio C Hamano
2017-08-16 17:58 ` [PATCH v2 2/4] commit: replace the raw buffer with strbuf in read_graft_line Patryk Obara
2017-08-16 17:58 ` [PATCH v2 3/4] commit: implement free_commit_graft Patryk Obara
2017-08-16 17:58 ` [PATCH v2 4/4] commit: rewrite read_graft_line Patryk Obara
2017-08-17 21:20 ` Junio C Hamano [this message]
2017-08-17 21:42 ` Patryk Obara
2017-08-18 1:59 ` [PATCH v3 0/4] Modernize read_graft_line implementation Patryk Obara
2017-08-18 1:59 ` [PATCH v3 1/4] sha1_file: fix definition of null_sha1 Patryk Obara
2017-08-18 1:59 ` [PATCH v3 2/4] commit: replace the raw buffer with strbuf in read_graft_line Patryk Obara
2017-08-18 6:29 ` Jeff King
2017-08-18 10:12 ` Patryk Obara
2017-08-18 11:50 ` Jeff King
2017-08-18 1:59 ` [PATCH v3 3/4] commit: allocate array using object_id size Patryk Obara
2017-08-18 1:59 ` [PATCH v3 4/4] commit: rewrite read_graft_line Patryk Obara
2017-08-18 6:43 ` Jeff King
2017-08-18 7:44 ` Junio C Hamano
2017-08-18 11:30 ` Patryk Obara
2017-08-18 11:45 ` Jeff King
2017-08-18 16:44 ` Junio C Hamano
2017-08-18 17:05 ` Patryk Obara
2017-08-18 18:29 ` Junio C Hamano
2017-08-18 2:20 ` [PATCH v3 0/4] Modernize read_graft_line implementation Junio C Hamano
2017-08-18 18:33 ` [PATCH v4 " Patryk Obara
2017-08-18 18:33 ` [PATCH v4 1/4] sha1_file: fix definition of null_sha1 Patryk Obara
2017-08-18 18:33 ` [PATCH v4 2/4] commit: replace the raw buffer with strbuf in read_graft_line Patryk Obara
2017-08-18 18:33 ` [PATCH v4 3/4] commit: allocate array using object_id size Patryk Obara
2017-08-18 18:33 ` [PATCH v4 4/4] commit: rewrite read_graft_line Patryk Obara
2017-08-18 18:38 ` Patryk Obara
2017-08-18 19:12 ` Junio C Hamano
2017-08-18 19:33 ` Patryk Obara
2017-08-18 19:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq378pgac1.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=patryk.obara@gmail$(echo .)com \
--cc=sandals@crustytoothpaste$(echo .)net \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox