public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Stefan Beller <sbeller@google•com>
Cc: Brandon Williams <bmwill@google•com>,
	"git\@vger.kernel.org" <git@vger•kernel.org>,
	Jens Lehmann <Jens.Lehmann@web•de>
Subject: Re: [PATCH] Documentation/fetch-options: emit recurse-submodules, jobs unconditionally
Date: Mon, 26 Sep 2016 13:54:45 -0700	[thread overview]
Message-ID: <xmqq37kmqt4a.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kbeq+Wznm=ChWO0tU5A_haPQ6DvKNHbK+8Y3es5OVcRag@mail.gmail.com> (Stefan Beller's message of "Mon, 26 Sep 2016 13:44:19 -0700")

Stefan Beller <sbeller@google•com> writes:

> After a bit more research, I think 8f0700dd33f (fetch/pull: Add the
> 'on-demand' value to the --recurse-submodules option) is the culprit,
> where this patch should have been squashed into, as that made the
> both locations word for word equal.

Hmph, my digging points to elsewhere.  7811d960 ("pull: Document the
"--[no-]recurse-submodules" options", 2011-02-07) which is older
than 8f0700dd ("fetch/pull: Add the 'on-demand' value to the
--recurse-submodules option", 2011-03-06) seems to be the real
change that pulled the description of recurse-submodules made in
fetch-options into "show this only when we are not describing pull".

Unfortunately it is not clear why we actively wanted to be sketchier
when showing "git help fetch"; otherwise the change would have been
made to the existing description there without adding a new entry to
"git-pull.txt".


  reply	other threads:[~2016-09-26 20:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-26 19:35 [PATCH] Documentation/fetch-options: emit recurse-submodules, jobs unconditionally Stefan Beller
2016-09-26 20:29 ` Junio C Hamano
2016-09-26 20:44   ` Stefan Beller
2016-09-26 20:54     ` Junio C Hamano [this message]
2016-09-26 21:14       ` Stefan Beller
2016-09-26 22:18     ` Brandon Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq37kmqt4a.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=Jens.Lehmann@web$(echo .)de \
    --cc=bmwill@google$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=sbeller@google$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox