From: Junio C Hamano <gitster@pobox•com>
To: Mike Rappazzo <rappazzo@gmail•com>
Cc: "Eric Sunshine" <sunshine@sunshineco•com>,
"Git List" <git@vger•kernel.org>,
"Nguyễn Thái Ngọc" <pclouds@gmail•com>
Subject: Re: [PATCH v3] worktree: add 'list' command
Date: Tue, 11 Aug 2015 08:46:20 -0700 [thread overview]
Message-ID: <xmqq37zpu8tv.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CANoM8SWeqxD2vWLQmEfxxxn8Dz4yPfjGOoOH=Azn1A3So+wz2Q@mail.gmail.com> (Mike Rappazzo's message of "Tue, 11 Aug 2015 07:41:21 -0400")
Mike Rappazzo <rappazzo@gmail•com> writes:
>>> + int is_bare = is_bare_repository();
>>
>> Please do not introduce decl-after-stmt.
>
> Since I reused this value below, I thought it would be acceptable.
Use of a new variable is fine. "Do not declare one in a block after
you already wrote statement" is what "decl-after-stmt not allowed"
means. In your patch:
+static int list(int ac, const char **av, const char *prefix)
+{
+ int main_only = 0;
+ struct option options[] = {
+ OPT_BOOL(0, "main-only", &main_only, N_("only list the main worktree")),
+ OPT_END()
+ };
+
+ ac = parse_options(ac, av, prefix, options, worktree_usage, 0);
+ if (ac)
+ usage_with_options(worktree_usage, options);
+
+ struct strbuf main_path = STRBUF_INIT;
+ const char* common_dir = get_git_common_dir();
+ int is_bare = is_bare_repository();
Three variables, main_path, common_dir and is_bare are declared here
after statements such as a call to parse_options(). Don't.
+static int list(int ac, const char **av, const char *prefix)
+{
+ int main_only = 0;
+ struct strbuf main_path = STRBUF_INIT;
+ const char *common_dir;
+ int is_bare;
+ struct option options[] = {
+ OPT_BOOL(0, "main-only", &main_only, N_("only list the main worktree")),
+ OPT_END()
+ };
+
+ ac = parse_options(ac, av, prefix, options, worktree_usage, 0);
+ if (ac)
+ usage_with_options(worktree_usage, options);
+
+ common_dir = get_git_common_dir();
+ int is_bare = is_bare_repository();
next prev parent reply other threads:[~2015-08-11 15:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 20:53 [PATCH v3] worktree: add 'list' command Michael Rappazzo
2015-08-10 20:53 ` Michael Rappazzo
2015-08-10 22:10 ` Junio C Hamano
2015-08-11 11:41 ` Mike Rappazzo
2015-08-11 15:46 ` Junio C Hamano [this message]
2015-08-11 2:55 ` David Turner
2015-08-11 11:42 ` Mike Rappazzo
2015-08-11 15:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq37zpu8tv.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)com \
--cc=rappazzo@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox