From: Junio C Hamano <gitster@pobox•com>
To: Michael Haggerty <mhagger@alum•mit.edu>
Cc: Stefan Beller <sbeller@google•com>, Jeff King <peff@peff•net>,
git@vger•kernel.org
Subject: Re: [PATCH 1/2] lockfile: allow file locking to be retried with a timeout
Date: Mon, 11 May 2015 11:04:54 -0700 [thread overview]
Message-ID: <xmqq38337zy1.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1430491977-25817-2-git-send-email-mhagger@alum.mit.edu> (Michael Haggerty's message of "Fri, 1 May 2015 16:52:56 +0200")
Michael Haggerty <mhagger@alum•mit.edu> writes:
> Signed-off-by: Michael Haggerty <mhagger@alum•mit.edu>
> ---
>
> Notes (discussion):
> It would be easy to also add a hold_lock_file_for_append_timeout(),
> but I can't yet think of an application for it.
>
> lockfile.c | 79 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
> lockfile.h | 16 +++++++++++--
> 2 files changed, 91 insertions(+), 4 deletions(-)
>
> diff --git a/lockfile.c b/lockfile.c
> index 9889277..30e65e9 100644
> --- a/lockfile.c
> +++ b/lockfile.c
> @@ -157,6 +157,80 @@ static int lock_file(struct lock_file *lk, const char *path, int flags)
> return lk->fd;
> }
>
> +static int sleep_microseconds(long us)
> +{
> + struct timeval tv;
> + tv.tv_sec = 0;
> + tv.tv_usec = us;
> + return select(0, NULL, NULL, NULL, &tv);
> +}
This is familiar for an old timer like me. It seems help.c uses
"poll(NULL, 0, timeout)" for "do nothing but wait" (and we have
compat/poll to help those who lack poll() by using select()).
As we do not need microseconds resolution here, either would be fine
;-)
next prev parent reply other threads:[~2015-05-11 18:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 14:52 [PATCH 0/2] Retry attempts to acquire the packed-refs lock Michael Haggerty
2015-05-01 14:52 ` [PATCH 1/2] lockfile: allow file locking to be retried with a timeout Michael Haggerty
2015-05-11 18:04 ` Junio C Hamano [this message]
2015-05-01 14:52 ` [PATCH 2/2] lock_packed_refs(): allow retries when acquiring the packed-refs lock Michael Haggerty
2015-05-01 16:13 ` Johannes Sixt
2015-05-02 3:47 ` Michael Haggerty
2015-05-02 21:43 ` Johannes Sixt
2015-05-11 9:31 ` Michael Haggerty
2015-05-01 17:51 ` Stefan Beller
2015-05-01 18:22 ` Jeff King
2015-05-02 5:19 ` Michael Haggerty
2015-05-04 17:31 ` Stefan Beller
2015-05-05 19:21 ` Jeff King
2015-05-11 10:26 ` Michael Haggerty
2015-05-11 16:49 ` Jeff King
2015-05-11 17:49 ` Stefan Beller
2015-05-11 17:50 ` Stefan Beller
2015-05-03 2:12 ` [PATCH 0/2] Retry attempts to acquire " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq38337zy1.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mhagger@alum$(echo .)mit.edu \
--cc=peff@peff$(echo .)net \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox