From: Junio C Hamano <gitster@pobox•com>
To: Anders Kaseorg <andersk@mit•edu>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] t5516-fetch-push: Correct misspelled pushInsteadOf
Date: Mon, 02 Mar 2015 11:43:03 -0800 [thread overview]
Message-ID: <xmqq385nb2yg.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1502282316150.7008@buzzword-bingo.mit.edu> (Anders Kaseorg's message of "Sat, 28 Feb 2015 23:18:14 -0500 (EST)")
Anders Kaseorg <andersk@mit•edu> writes:
> Signed-off-by: Anders Kaseorg <andersk@mit•edu>
> ---
> t/t5516-fetch-push.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh
> index 85c7fec..594d7a6 100755
> --- a/t/t5516-fetch-push.sh
> +++ b/t/t5516-fetch-push.sh
> @@ -238,7 +238,7 @@ test_expect_success 'push with pushInsteadOf' '
> test_expect_success 'push with pushInsteadOf and explicit pushurl (pushInsteadOf should not rewrite)' '
> mk_empty testrepo &&
> test_config "url.trash2/.pushInsteadOf" testrepo/ &&
> - test_config "url.trash3/.pusnInsteadOf" trash/wrong &&
> + test_config "url.trash3/.pushInsteadOf" trash/wrong &&
> test_config remote.r.url trash/wrong &&
> test_config remote.r.pushurl "testrepo/" &&
> git push r refs/heads/master:refs/remotes/origin/master &&
Interesting.
Now an obvious and natural question after seeing this change is how
the original test passed with misspelled configuration. Is a test
that pushes into "trash/wrong" checking the right outcome? If the
reason why the existing tests passed without this patch is because
they do not test the right thing, then shouldn't they be corrected
together with the above fix?
next prev parent reply other threads:[~2015-03-02 19:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-01 4:18 [PATCH] t5516-fetch-push: Correct misspelled pushInsteadOf Anders Kaseorg
2015-03-02 19:43 ` Junio C Hamano [this message]
2015-03-03 15:51 ` Michael J Gruber
2015-03-03 20:06 ` Junio C Hamano
2015-03-04 9:36 ` Michael J Gruber
2015-03-04 9:43 ` Anders Kaseorg
2015-03-04 10:10 ` Michael J Gruber
2015-03-04 20:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq385nb2yg.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=andersk@mit$(echo .)edu \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox