From: Junio C Hamano <gitster@pobox•com>
To: "Paul E. McKenney" <paulmck@linux•vnet.ibm.com>
Cc: git@vger•kernel.org, mingo@kernel•org
Subject: Re: Is there some way to suppress Cc email only to stable?
Date: Mon, 09 Feb 2015 12:57:11 -0800 [thread overview]
Message-ID: <xmqq386eby6w.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150209194224.GA27482@linux.vnet.ibm.com> (Paul E. McKenney's message of "Mon, 9 Feb 2015 11:42:24 -0800")
"Paul E. McKenney" <paulmck@linux•vnet.ibm.com> writes:
> I need to be able to put the following Cc in a git commit:
>
> Cc: <stable@vger•kernel.org>
>
> Yet I cannot allow git-send-email to actually send email to that address,
> lest I get an automated nastygram in response. I found the --to-cmd=
> option to git-send-email, but it looks to only add email addresses, never
> delete them. I also found the --suppress-cc= option to git-send-email,
> but it appears to suppress all Cc emails, not just selected ones.
>
> One approach that occurred to me is to hand-edit the files produced
> by git-format-patch, removing stable@vger•kernel.org entirely prior to
> using git-send-email. However, this is a bit error-prone. Yes, I could
> script it, but with my luck, I will eventually end up having my script
> mangle some patch, for example to the Linux kernel's MAINTAINERS file.
> Furthermore, this approach means that people reviewing the patches
> cannot see the Cc stable entries (though I could presumably comment them
> out somehow).
>
> Another approach is to add the stable Ccs just before doing the pull
> request, by my upstream maintainer is not fond of that approach. Nor am
> I, as it would be all to easy to forget to add the stable Ccs. Or to
> get them wrong.
>
> I can't be the only person wanting to do something like this. So is
> there some git option that I am missing here?
No, I do not think we have a way to blacklist certain recipient
addresses from getting passed to the MTA, and I do not object to
addition of such a mechanism if there is a valid need to do so.
It feels a bit too convoluted to say "Cc: to this address" in the
log message and then "nonono, I do not want to send there", though.
Why do you want to have Cc: in the log message if you do not want to
send e-mail to that address in the first place? Allowing the
behaviour you are asking for would mean that those who see that the
commit appeared on a branch would not be able to assume that the
patch has already been sent to the stable review address, no?
next prev parent reply other threads:[~2015-02-09 20:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 19:42 Is there some way to suppress Cc email only to stable? Paul E. McKenney
2015-02-09 20:57 ` Junio C Hamano [this message]
2015-02-09 21:10 ` Paul E. McKenney
2015-02-09 21:17 ` Junio C Hamano
2015-02-09 21:43 ` Paul E. McKenney
2015-02-09 21:46 ` Junio C Hamano
2015-02-09 22:01 ` Paul E. McKenney
2015-02-09 21:53 ` Jonathan Nieder
2015-02-09 23:35 ` Paul E. McKenney
2015-02-10 0:03 ` Greg KH
2015-02-10 0:35 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq386eby6w.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mingo@kernel$(echo .)org \
--cc=paulmck@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox