public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: David Aguilar <davvid@gmail•com>
Cc: git@vger•kernel.org, Adria Farres <14farresa@gmail•com>
Subject: Re: --trust-exit-code not working
Date: Fri, 14 Nov 2014 12:41:16 -0800	[thread overview]
Message-ID: <xmqq389l347n.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20141114161235.GA30086@vimeitor> (Adria Farres's message of "Fri, 14 Nov 2014 17:12:35 +0100")

David, I think this is about your 2b52123f (difftool: add support
for --trust-exit-code, 2014-10-26).  If you have time can you help
Adria?

Thanks.


Adria Farres <14farresa@gmail•com> writes:

> Hello!,
>
> I sent an email last week, but I'm not sure if I sent it incorrectly, or the
> formatting was very bad, or it went unnoticed. A few days ago a great soul was
> kind enough to create the --trust-exit-code option that made git respect the
> exit code of the difftool. Unfortunately, I haven't been able to make it work.
> Exiting vimdiff with :cq doesn't seem to make git quit, as it keeps pushing new
> files to be diffed. I tried meld and the exact same thing. I'm confident that
> exiting with :cq gives an error, as I have checked it, and I'm using git
> 2.2.0.rc1.
>
> Am I missing something important? Has anyone managed to make it work with
> vimdiff and meld? Sorry for bringing that up so late and for being a
> disturbance.
>
> Thank you,
>
> Adria

next prev parent reply	other threads:[~2014-11-14 20:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-14 16:12 --trust-exit-code not working Adria Farres
2014-11-14 20:41 ` Junio C Hamano [this message]
2014-11-14 21:07   ` David Aguilar
2014-11-14 21:55 ` David Aguilar
  -- strict thread matches above, loose matches on Subject: below --
2014-11-08 17:23 Adri Farr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq389l347n.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=14farresa@gmail$(echo .)com \
    --cc=davvid@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox