From: Junio C Hamano <gitster@pobox•com>
To: Zoltan Klinger <zoltan.klinger@gmail•com>
Cc: GIT Mailing-list <git@vger•kernel.org>
Subject: Re: [PATCH] grep: fix match highlighting for combined patterns with context lines
Date: Wed, 22 Oct 2014 12:14:13 -0700 [thread overview]
Message-ID: <xmqq38afj4sa.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAKJhZwTQpxiFp1BLed9jHRaPeF_ZuXQ7u6YGNp--UjyAyGZerw@mail.gmail.com> (Zoltan Klinger's message of "Wed, 22 Oct 2014 11:45:19 +1100")
Zoltan Klinger <zoltan.klinger@gmail•com> writes:
>> Junio C Hamano <gitster@pobox•com> writes:
>>
>> It turns out that the result of such a change becomes more readable
>> than the original, in that it makes it clear that reinspection of
>> the lines are done only for matched ones and not context lines.
>>
>>
> Agree, it looks much clearer now. Happy if you squashed your
> change (commit da736e6) in zk/grep-color-words branch.
OK, will do. Thanks.
next prev parent reply other threads:[~2014-10-22 19:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 5:56 [PATCH] grep: fix match highlighting for combined patterns with context lines Zoltan Klinger
2014-10-21 19:23 ` Junio C Hamano
2014-10-21 22:40 ` Junio C Hamano
2014-10-22 0:45 ` Zoltan Klinger
2014-10-22 19:14 ` Junio C Hamano [this message]
2014-10-26 18:15 ` René Scharfe
2014-10-27 18:23 ` [PATCH][RFC] grep: add color.grep.matchcontext and color.grep.matchselected René Scharfe
2014-10-27 19:29 ` Junio C Hamano
2014-10-27 19:47 ` Junio C Hamano
2014-10-27 23:32 ` Zoltan Klinger
2014-10-28 16:50 ` Junio C Hamano
2014-10-28 18:19 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq38afj4sa.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=zoltan.klinger@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox