From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Jonathan Nieder <jrnieder@gmail•com>, git@vger•kernel.org
Subject: Re: [PATCH] t7300: repair filesystem permissions with test_when_finished
Date: Wed, 02 Jul 2014 13:06:36 -0700 [thread overview]
Message-ID: <xmqq38ejh6er.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqq7g3vh6h1.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Wed, 02 Jul 2014 13:05:14 -0700")
Junio C Hamano <gitster@pobox•com> writes:
> It tests that "clean -d" is happy if a blind rmdir(2) removes the
> directory. If it fails for whatever reason (e.g. add "exit(0)" at
> the beginning of cmd_clean(), for example) to remove the directory,
> we do leave an empty unreadable directory behind.
>
> But as long as that directory is empty, that will not cause us to
> remove the trash directory at the end, so we should be OK.
s/remove/fail to &/; sorry for the noise.
next prev parent reply other threads:[~2014-07-02 20:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 18:44 [PATCH] t7300: repair filesystem permissions with test_when_finished Jeff King
2014-07-02 19:01 ` Jonathan Nieder
2014-07-02 19:03 ` Jeff King
2014-07-02 20:05 ` Junio C Hamano
2014-07-02 20:06 ` Junio C Hamano [this message]
2014-07-02 19:11 ` [RFH] "git clean" deletes excluded files in untracked directories Jeff King
2014-07-22 21:39 ` Junio C Hamano
2014-07-22 22:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq38ejh6er.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox