From: Junio C Hamano <gitster@pobox•com>
To: Jiang Xin <worldhello.net@gmail•com>
Cc: Duy Nguyen <pclouds@gmail•com>,
Eric Sunshine <sunshine@sunshineco•com>,
Brian Gesiak <modocache@gmail•com>,
Git List <git@vger•kernel.org>
Subject: Re: [PATCH v3 2/2] blame: use a helper to get suitable blame_date_width
Date: Mon, 21 Apr 2014 12:19:39 -0700 [thread overview]
Message-ID: <xmqq38h6a3sk.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqqfvl6a9ar.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Mon, 21 Apr 2014 10:20:44 -0700")
Junio C Hamano <gitster@pobox•com> writes:
> What I am wondering is if we can do something
> like this:
> ...
Nah, that is a lot more stupid than just doing
> In code:
>
> blame_date_width = strtoul(_("4 years, 11 months ago"), NULL, 10) + 1;
>
> In git.pot:
>
> #. This string is used to tell us the maximum display width for a
> #. relative timestamp in "git blame" output. For C locale, "4 years,
> #. 11 months ago", which takes 22 places, is the longest among various
> #. forms of relative timestamps, but your language may need more or
> #. fewer display columns.
> msgid "4 years, 11 months ago"
> msgstr ""
>
> In de.po:
> #. This string is used to tell us the maximum display width for a
> #. relative timestamp in "git blame" output. For C locale, "4 years,
> #. 11 months ago", which takes 22 places, is the longest among various
> #. forms of relative timestamps, but your language may need more or
> #. fewer display columns.
> msgid "4 years, 11 months ago"
> msgstr ""vor 4 Jahren, und 11 Monaten"
which is essentially how your very original looked like (modulo the
comments). So let's not try to be clever or cute, and just have a
good instruction in the TRANSLATORS comments.
Sorry for flipping and flopping on this one.
next prev parent reply other threads:[~2014-04-21 19:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 8:44 [PATCH] blame: add correct paddings in time_buf for align Jiang Xin
2014-04-18 14:42 ` Duy Nguyen
2014-04-18 17:08 ` Junio C Hamano
2014-04-19 0:20 ` Duy Nguyen
2014-04-20 16:13 ` [PATCH v2 0/2] peroper align of datetime filed of git-blame Jiang Xin
2014-04-20 16:13 ` [PATCH v2 1/2] bugfix: fix broken time_buf paddings for git-blame Jiang Xin
2014-04-20 20:28 ` Eric Sunshine
2014-04-20 16:13 ` [PATCH v2 2/2] blame: use different blame_date_width for different locale Jiang Xin
2014-04-20 21:40 ` Junio C Hamano
2014-04-21 6:02 ` [PATCH v3 0/2] peroper align of datetime filed of git-blame Jiang Xin
2014-04-21 6:02 ` [PATCH v3 1/2] bugfix: fix broken time_buf paddings for git-blame Jiang Xin
2014-04-21 6:02 ` [PATCH v3 2/2] blame: use a helper to get suitable blame_date_width Jiang Xin
2014-04-21 17:20 ` Junio C Hamano
2014-04-21 19:19 ` Junio C Hamano [this message]
2014-04-22 12:25 ` Jiang Xin
2014-04-22 14:39 ` [PATCH v4 0/2] peroper align of datetime filed of git-blame Jiang Xin
2014-04-22 14:39 ` [PATCH v4 1/2] bugfix: fix broken time_buf paddings for git-blame Jiang Xin
2014-04-22 14:39 ` [PATCH v4 2/2] blame: dynamic blame_date_width for different locales Jiang Xin
2014-04-22 10:01 ` [PATCH v2 2/2] blame: use different blame_date_width for different locale David Kastrup
2014-04-22 12:16 ` Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq38h6a3sk.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=modocache@gmail$(echo .)com \
--cc=pclouds@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
--cc=worldhello.net@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox