public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Michael Haggerty <mhagger@alum•mit.edu>
Cc: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>, git <git@vger•kernel.org>
Subject: Re: Project idea: strbuf allocation modes
Date: Fri, 18 Apr 2014 17:55:19 -0700	[thread overview]
Message-ID: <xmqq38hab0js.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <5351854E.1080602@alum.mit.edu> (Michael Haggerty's message of "Fri, 18 Apr 2014 22:04:30 +0200")

Michael Haggerty <mhagger@alum•mit.edu> writes:

> On 04/18/2014 07:21 PM, Junio C Hamano wrote:
>> Michael Haggerty <mhagger@alum•mit.edu> writes:
>> 
>>> The Idea
>>> ========
>>>
>>> I would like to see strbuf enhanced to allow it to use memory that it
>>> doesn't own (for example, stack-allocated memory), while (optionally)
>>> allowing it to switch over to using allocated memory if the string grows
>>> past the size of the pre-allocated buffer.
>> 
>> I'd like to see these characteristics, but I would want to see that
>> this is done entirely internally inside the strbuf implementation
>> without any API impact, other than the initialisation.  I do not
>> ...
>
> I think that's exactly what I described.  The only thing that would have
> to change in the strbuf behavior (aside from initialization) is that a
> buffer-growing operation might die if the string would grow outside of
> the bounds of the existing buffer when STRBUF_FIXED_MEMORY is set.

Yup, we are in agreement ;-)

More seriously, sorry for sounding as if I was objecting. I should
have edited s/but/and/ before sending my response out.

Thanks.

next prev parent reply	other threads:[~2014-04-19  0:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-08 15:44 Students project on Git (Ensimag) Matthieu Moy
2014-04-18 13:50 ` Project idea: strbuf allocation modes Michael Haggerty
2014-04-18 17:21   ` Junio C Hamano
2014-04-18 20:04     ` Michael Haggerty
2014-04-19  0:55       ` Junio C Hamano [this message]
2014-04-22  7:07   ` Matthieu Moy
2014-04-22  9:09     ` Michael Haggerty
2014-04-22 10:38       ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq38hab0js.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
    --cc=git@vger$(echo .)kernel.org \
    --cc=mhagger@alum$(echo .)mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox