From: Junio C Hamano <gitster@pobox•com>
To: David Kastrup <dak@gnu•org>
Cc: Sun He <sunheehnus@gmail•com>, git@vger•kernel.org
Subject: Re: [PATCH] Rewrite git-compat-util.h:skip_prefix() as a loop
Date: Thu, 27 Feb 2014 14:16:13 -0800 [thread overview]
Message-ID: <xmqq38j4xkuq.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <87k3cg47o6.fsf@fencepost.gnu.org> (David Kastrup's message of "Thu, 27 Feb 2014 21:33:45 +0100")
David Kastrup <dak@gnu•org> writes:
> Junio C Hamano <gitster@pobox•com> writes:
>
>> Sun He <sunheehnus@gmail•com> writes:
>>
>>> Signed-off-by: Sun He <sunheehnus@gmail•com>
>>> ---
>>> git-compat-util.h | 4 ++--
>>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/git-compat-util.h b/git-compat-util.h
>>> index cbd86c3..4daa6cf 100644
>>> --- a/git-compat-util.h
>>> +++ b/git-compat-util.h
>>> @@ -357,8 +357,8 @@ extern int suffixcmp(const char *str, const char *suffix);
>>>
>>> static inline const char *skip_prefix(const char *str, const char *prefix)
>>> {
>>> - size_t len = strlen(prefix);
>>> - return strncmp(str, prefix, len) ? NULL : str + len;
>>> + while( *prefix != '\0' && *str++ == *prefix++ );
>>> + return *prefix == '\0' ? str : NULL;
>>
>> Documentation/CodingGuidelines?
>
> Mostly relevant for tabification here, not helping much otherwise.
"Imitate existing code" would let you spot that we have SP outside
the () pair, not inside, for controls like while/for/if, and we
usually do not explicitly compare things with 0, NULL or '\0'.
Together with the "empty statement should occupy its own line" you
mentioned, I tend to agree with you that some people may benefit
from them explicitly spelled out.
next prev parent reply other threads:[~2014-02-27 22:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 12:13 [PATCH] Rewrite git-compat-util.h:skip_prefix() as a loop Sun He
2014-02-27 19:35 ` Junio C Hamano
2014-02-27 20:33 ` David Kastrup
2014-02-27 22:16 ` Junio C Hamano [this message]
2014-02-28 6:17 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq38j4xkuq.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=dak@gnu$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=sunheehnus@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox