From: Junio C Hamano <gitster@pobox•com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 0/4] Good bye fnmatch
Date: Tue, 18 Feb 2014 11:28:06 -0800 [thread overview]
Message-ID: <xmqq38jgfcft.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1392429709-9237-1-git-send-email-pclouds@gmail.com> ("Nguyễn Thái Ngọc Duy"'s message of "Sat, 15 Feb 2014 09:01:45 +0700")
Nguyễn Thái Ngọc Duy <pclouds@gmail•com> writes:
> Long story short, we wanted globbing wildcard "**" so I ripped
> wildmatch library from rsync to do it. And it opened a possibility
> to replace fnmatch completely, which would provide consistent behavior
> across platforms (native fnmatch behaves differently on many corner
> cases), and some performance gains. I started fnmatch replacement with
> 4917e1e (Makefile: promote wildmatch to be the default fnmatch
> implementation - 2013-05-30). This is the final step.
Nice.
>
> Nguyễn Thái Ngọc Duy (4):
> Use wildmatch() directly without fnmatch() wrapper
> Revert "test-wildmatch: add "perf" command to compare wildmatch and fnmatch"
> Stop using fnmatch (either native or compat)
> Actually remove compat fnmatch source code
>
> Makefile | 22 --
> builtin/apply.c | 2 +-
> builtin/branch.c | 2 +-
> builtin/describe.c | 2 +-
> builtin/for-each-ref.c | 2 +-
> builtin/ls-remote.c | 2 +-
> builtin/name-rev.c | 2 +-
> builtin/reflog.c | 2 +-
> builtin/replace.c | 2 +-
> builtin/show-branch.c | 2 +-
> builtin/tag.c | 2 +-
> compat/fnmatch/fnmatch.c (gone) | 494 ----------------------------------------
> compat/fnmatch/fnmatch.h (gone) | 84 -------
> config.mak.uname | 10 -
> configure.ac | 28 ---
> diffcore-order.c | 2 +-
> dir.c | 11 +-
> git-compat-util.h | 12 -
> refs.c | 2 +-
> revision.c | 2 +-
> t/t3070-wildmatch.sh | 13 --
> test-wildmatch.c | 79 -------
> 22 files changed, 20 insertions(+), 759 deletions(-)
prev parent reply other threads:[~2014-02-18 19:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 2:01 [PATCH 0/4] Good bye fnmatch Nguyễn Thái Ngọc Duy
2014-02-15 2:01 ` [PATCH 1/4] Use wildmatch() directly without fnmatch() wrapper Nguyễn Thái Ngọc Duy
2014-02-15 2:01 ` [PATCH 2/4] Revert "test-wildmatch: add "perf" command to compare wildmatch and fnmatch" Nguyễn Thái Ngọc Duy
2014-02-15 2:01 ` [PATCH 3/4] Stop using fnmatch (either native or compat) Nguyễn Thái Ngọc Duy
2014-02-15 2:01 ` [PATCH 4/4] Actually remove compat fnmatch source code Nguyễn Thái Ngọc Duy
2014-02-15 8:23 ` [PATCH 0/4] Good bye fnmatch David Kastrup
2014-02-15 8:29 ` Duy Nguyen
2014-02-15 8:49 ` David Kastrup
2014-02-18 19:28 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq38jgfcft.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox