From: Junio C Hamano <gitster@pobox•com>
To: Nicolas Vigier <boklm@mars-attacks•org>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] test the commit.gpgsign config option
Date: Mon, 16 Dec 2013 09:05:02 -0800 [thread overview]
Message-ID: <xmqq38lsrakh.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1387202104-17580-1-git-send-email-boklm@mars-attacks.org> (Nicolas Vigier's message of "Mon, 16 Dec 2013 14:55:04 +0100")
Nicolas Vigier <boklm@mars-attacks•org> writes:
> The tests are checking that :
>
> - when commit.gpgsign is true, "git commit" creates signed commits
>
> - when commit.gpgsign is false, "git commit" creates unsigned commits
>
> - when commit.gpgsign is true, "git commit --no-gpg-sign" creates
> unsigned commits
>
> - when commit.gpgsign is true, "git rebase -f" creates signed commits
>
> Signed-off-by: Nicolas Vigier <boklm@mars-attacks•org>
> ---
> t/t7510-signed-commit.sh | 25 +++++++++++++++++++++----
> 1 file changed, 21 insertions(+), 4 deletions(-)
>
> diff --git a/t/t7510-signed-commit.sh b/t/t7510-signed-commit.sh
> index 1d3c56fe61fa..537bfba76ecf 100755
> --- a/t/t7510-signed-commit.sh
> +++ b/t/t7510-signed-commit.sh
> @@ -25,12 +25,29 @@ test_expect_success GPG 'create signed commits' '
> git tag fourth-unsigned &&
>
> test_tick && git commit --amend -S -m "fourth signed" &&
> - git tag fourth-signed
> + git tag fourth-signed &&
> +
> + git config commit.gpgsign true &&
> + echo 5 >file && test_tick && git commit -a -m "fifth signed" &&
> + git tag fifth-signed &&
> +
> + git config commit.gpgsign false &&
> + echo 6 >file && test_tick && git commit -a -m "sixth" &&
> + git tag sixth-unsigned &&
> +
> + git config commit.gpgsign true &&
> + echo 7 >file && test_tick && git commit -a -m "seventh" --no-gpg-sign &&
> + git tag seventh-unsigned &&
> +
> + test_tick && git rebase -f HEAD^^ && git tag sixth-signed HEAD^ &&
> + git tag seventh-signed &&
> +
> + git config --unset commit.gpgsign
If any of the above fail, the next test will run with an unknown
random value in commit.gpgsign depending on where the sequence
failed. Use one test_when_finished with test_unconfig at the very
beginning, perhaps.
next prev parent reply other threads:[~2013-12-16 17:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 0:57 What's cooking in git.git (Dec 2013, #03; Thu, 12) Junio C Hamano
2013-12-13 1:05 ` Duy Nguyen
2013-12-13 20:58 ` Junio C Hamano
2013-12-13 7:39 ` Torsten Bögershausen
2013-12-13 20:58 ` Junio C Hamano
2013-12-16 5:34 ` Junio C Hamano
2013-12-16 12:30 ` Nicolas Vigier
2013-12-16 17:14 ` Junio C Hamano
2013-12-16 13:55 ` [PATCH] test the commit.gpgsign config option Nicolas Vigier
2013-12-16 17:05 ` Junio C Hamano [this message]
2013-12-17 23:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq38lsrakh.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=boklm@mars-attacks$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox