From: Junio C Hamano <gitster@pobox•com>
To: Felipe Contreras <felipe.contreras@gmail•com>
Cc: git@vger•kernel.org, Sverre Rabbelier <srabbelier@gmail•com>,
Richard Hansen <rhansen@bbn•com>,
Ramsay Jones <ramsay@ramsay1•demon.co.uk>
Subject: Re: [PATCH v5 06/10] fast-export: add new --refspec option
Date: Wed, 06 Nov 2013 13:00:42 -0800 [thread overview]
Message-ID: <xmqq38n98cud.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAMP44s246M5DaeX80tqzfjRWnbE4vKh-vp_tLW-qAQUFFPsP0Q@mail.gmail.com> (Felipe Contreras's message of "Thu, 31 Oct 2013 12:41:31 -0600")
Felipe Contreras <felipe.contreras@gmail•com> writes:
> On Thu, Oct 31, 2013 at 12:26 PM, Junio C Hamano <gitster@pobox•com> wrote:
>> Felipe Contreras <felipe.contreras@gmail•com> writes:
>>
>>> +test_expect_success 'use refspec' '
>>> + git fast-export --refspec refs/heads/master:refs/heads/foobar master | \
>>> + grep "^commit " | sort | uniq > actual &&
>>
>> It feels somewhat redundant that you have to twice say that you are
>> pushing your "master", once with --refspec and then the branch
>> name. Is this the best we can do?
>
> As this has been discussed before and no other solution came forward, yes.
We need to take that "no other solution came forward" with a grain
of salt. After all, this is your itch, and if nobody was interested
in helping you (which I think that we both understand entirely
plausible, given the recent history), it only means you didn't think
of any other solution.
I didn't think things through, but at the external UI level, I see a
possibility of a nicer way to express the above.
In our "push" refspec (and export is about pushing what we have), a
colonless refspec A is a short-hand for A:A, so the traditional
git fast-export master
can be thought of, in a new world order with a patch that lets you
do a ref mapping, a short-hand for an identical mapping:
git fast-export master:master
It follows that the syntax naturally support
git fast-export refs/heads/master:refs/heads/foobar
I would think.
That approach lets you express ref mapping without a new option
--refspec, which goes contrary to existing UI for any commands in
Git (I think nobody takes refspec as a value to a dashed-option in
the transport; both in fetch and push, they are proper operands,
i.e. command line arguments to the command), no?
next prev parent reply other threads:[~2013-11-06 21:00 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 9:36 [PATCH v5 10/10] transport-helper: add support to delete branches Felipe Contreras
2013-10-31 9:36 ` [PATCH v5 00/10] transport-helper: updates Felipe Contreras
2013-10-31 17:59 ` Max Horn
2013-10-31 18:10 ` Junio C Hamano
2013-10-31 18:30 ` Felipe Contreras
2013-10-31 18:34 ` Junio C Hamano
2013-10-31 18:41 ` Max Horn
2013-11-11 5:09 ` [PATCH v5 11/10] test-hg.sh: tests are now expected to pass Richard Hansen
2013-11-11 5:10 ` [PATCH v5 12/10] remote-bzr: support the new 'force' option Richard Hansen
2013-11-11 11:51 ` Felipe Contreras
2013-11-11 18:12 ` Richard Hansen
2013-11-11 18:15 ` Felipe Contreras
2013-10-31 9:36 ` [PATCH v5 01/10] transport-helper: fix extra lines Felipe Contreras
2013-10-31 18:16 ` Junio C Hamano
2013-10-31 9:36 ` [PATCH v5 08/10] fast-import: add support to delete refs Felipe Contreras
2013-10-31 18:41 ` Max Horn
2013-10-31 9:36 ` [PATCH v5 05/10] fast-export: improve argument parsing Felipe Contreras
2013-10-31 9:36 ` [PATCH v5 06/10] fast-export: add new --refspec option Felipe Contreras
2013-10-31 18:26 ` Junio C Hamano
2013-10-31 18:41 ` Felipe Contreras
2013-11-06 21:00 ` Junio C Hamano [this message]
2013-11-06 22:14 ` Jeff King
2013-11-06 22:31 ` Junio C Hamano
2013-11-06 22:41 ` Junio C Hamano
2013-11-08 23:44 ` Junio C Hamano
2013-11-09 0:06 ` Jeff King
2013-11-07 1:00 ` Felipe Contreras
2013-10-31 9:36 ` [PATCH v5 03/10] transport-helper: add 'force' to 'export' helpers Felipe Contreras
2013-10-31 18:21 ` Junio C Hamano
2013-10-31 18:55 ` Felipe Contreras
2013-10-31 19:07 ` Junio C Hamano
2013-11-01 14:49 ` Junio C Hamano
2013-11-01 15:37 ` Felipe Contreras
2013-11-01 16:35 ` Junio C Hamano
2013-11-01 17:28 ` Eric Sunshine
2013-11-11 5:01 ` [PATCH] fixup! " Richard Hansen
2013-10-31 9:36 ` [PATCH v5 09/10] fast-export: add support to delete refs Felipe Contreras
2013-10-31 19:29 ` Max Horn
2013-10-31 19:41 ` Felipe Contreras
2013-10-31 19:47 ` Max Horn
2013-10-31 19:53 ` Felipe Contreras
2013-10-31 22:38 ` Max Horn
2013-10-31 9:36 ` [PATCH v5 07/10] transport-helper: add support for old:new refspec Felipe Contreras
2013-10-31 9:36 ` [PATCH v5 04/10] transport-helper: check for 'forced update' message Felipe Contreras
2013-10-31 9:36 ` [PATCH v5 02/10] transport-helper: don't update refs in dry-run Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq38n98cud.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=felipe.contreras@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=ramsay@ramsay1$(echo .)demon.co.uk \
--cc=rhansen@bbn$(echo .)com \
--cc=srabbelier@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox