From: Junio C Hamano <gitster@pobox•com>
To: Felipe Contreras <felipe.contreras@gmail•com>
Cc: git@vger•kernel.org, Erik Faye-Lund <kusmabite@gmail•com>,
Elijah Newren <newren@gmail•com>,
Thiago Farina <tfransosi@gmail•com>
Subject: Re: [PATCH 2/2] fast-export: refactor get_tags_and_duplicates()
Date: Tue, 03 Sep 2013 13:17:48 -0700 [thread overview]
Message-ID: <xmqq38plr76b.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqqsixlr8p2.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Tue, 03 Sep 2013 12:44:57 -0700")
Junio C Hamano <gitster@pobox•com> writes:
> Felipe Contreras <felipe.contreras@gmail•com> writes:
>
>> Split into a separate helper function get_commit() so that the part that
>> finds the relevant commit, and the part that does something with it
>> (handle tag object, etc.) are in different places.
>>
>> No functional changes.
>
> Actually, the old code used to use commit unchecked if e->item->type
> said it is OBJ_COMMIT but e->item was somehow NULL. The new code
> checks ...
Nah, I am an idiot. We will segfault where we check e->item->type
before reaching that far down the code either way, so this is really
a no-op but makes it easier to fix (if we wanted to---I do not think
it matters that much).
prev parent reply other threads:[~2013-09-03 20:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-01 7:05 [PATCH 0/2] fast-export: simplification Felipe Contreras
2013-09-01 7:05 ` [PATCH 1/2] fast-export: make extra_refs global Felipe Contreras
2013-09-01 7:05 ` [PATCH 2/2] fast-export: refactor get_tags_and_duplicates() Felipe Contreras
2013-09-03 19:44 ` Junio C Hamano
2013-09-03 20:17 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq38plr76b.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=felipe.contreras@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=kusmabite@gmail$(echo .)com \
--cc=newren@gmail$(echo .)com \
--cc=tfransosi@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox