From: Junio C Hamano <gitster@pobox•com>
To: Eric Sunshine <sunshine@sunshineco•com>
Cc: Brian Gernhardt <brian@gernhardtsoftware•com>,
"git\@vger.kernel.org List" <git@vger•kernel.org>
Subject: Re: t3010 broken by 2eac2a4
Date: Thu, 22 Aug 2013 14:43:58 -0700 [thread overview]
Message-ID: <xmqq38q1qu3l.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPig+cSEQLk2M+X5QP7mkm846wqqHRCjPHgO7O3URvNcsYO6+w@mail.gmail.com> (Eric Sunshine's message of "Thu, 22 Aug 2013 17:35:19 -0400")
Eric Sunshine <sunshine@sunshineco•com> writes:
> On Thu, Aug 22, 2013 at 5:32 PM, Junio C Hamano <gitster@pobox•com> wrote:
>> Eric Sunshine <sunshine@sunshineco•com> writes:
>>
>>> On Thu, Aug 22, 2013 at 5:16 PM, Junio C Hamano <gitster@pobox•com> wrote:
>>>> Eric Sunshine <sunshine@sunshineco•com> writes:
>>>>
>>>>> I can confirm this failure on OS X, however,...
>>>
>>> Thanks for the explanation.
>>
>> Now, I am curious how it breaks on OS X.
>>
>> My suspition is that "ignore_case" may have something to do with it,
>> but what 2eac2a4c (ls-files -k: a directory only can be killed if
>> the index has a non-directory, 2013-08-15) uses are the bog-standard
>> cache_name_exists() and directory_exists_in_index(), so one of these
>> internal API implementation has trouble on case insensitive
>> filesystems, perhaps? I dunno.
>
> That's exactly my suspicion at the moment. It's an obvious difference
> between Linux and OS X. I'm just in the process of trying to compare
> between the two platforms.
Or perhaps de->d_type does not exist? In such a case, we end up
doing get_index_dtype() via get_dtype(), but in this codepath I
suspect that we do not want to. We are interested in the type of
the entity on the filesystem.
next prev parent reply other threads:[~2013-08-22 21:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 20:31 t3010 broken by 2eac2a4 Brian Gernhardt
2013-08-21 21:41 ` Junio C Hamano
2013-08-22 20:54 ` Eric Sunshine
2013-08-22 21:16 ` Junio C Hamano
2013-08-22 21:22 ` Eric Sunshine
2013-08-22 21:32 ` Junio C Hamano
2013-08-22 21:35 ` Eric Sunshine
2013-08-22 21:43 ` Junio C Hamano [this message]
2013-08-22 21:59 ` Eric Sunshine
2013-08-22 22:53 ` Eric Sunshine
2013-08-22 23:12 ` Junio C Hamano
2013-08-22 23:15 ` Eric Sunshine
2013-08-23 4:32 ` Eric Sunshine
2013-08-23 5:36 ` Junio C Hamano
2013-08-23 9:19 ` Eric Sunshine
2013-08-23 17:15 ` Junio C Hamano
2013-08-23 18:51 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq38q1qu3l.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=brian@gernhardtsoftware$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox