Subject: Re: [PATCH v3 1/8] parseopt: extract subcommand handling from parse_options_step()

From: Junio C Hamano <[email-masked]>
Date: Tue, 10 Mar 2026 21:20:19 -0700

Jiamu Sun <[email-masked]> writes:

> On Tue, Mar 10, 2026 at 05:46:12AM -0700, Karthik Nayak wrote:
>> > +			if (ctx->has_subcommands) {
>> > +				return handle_subcommand(ctx, arg, options,
>> > +							 usagestr);
>> >  			}
>> > +
>> 
>> Nit: we try to avoid braces around single statement blocks.
>
> I'm not sure if we should drop the braces in this case.

You should.

You can tell that it is a single statement immediately after seeing
the beginning of the line, which says "return".  It does not matter
how many lines the function call that follows "return" spans.