From: Junio C Hamano <gitster@pobox•com>
To: Jacob Keller <jacob.e.keller@intel•com>
Cc: Phil Hord <phil.hord@gmail•com>, Jeff King <peff@peff•net>,
<git@vger•kernel.org>
Subject: Re: [RFC PATCH 0/2] fetch --prune performance problem
Date: Mon, 23 Jun 2025 16:41:29 -0700 [thread overview]
Message-ID: <xmqq4iw63u1i.fsf@gitster.g> (raw)
In-Reply-To: <f11bf463-0005-43d2-b642-ede130d1f44c@intel.com> (Jacob Keller's message of "Mon, 23 Jun 2025 16:32:35 -0700")
Jacob Keller <jacob.e.keller@intel•com> writes:
>>> Alternatively, the dangling message could just mention where it the
>>> now-dangling symref points at, something like:
>>>
>>> - [deleted] (none) -> origin/branches
>>> - [deleted] (none) -> origin/main
>>> - [deleted] (none) -> origin/other
>>> (refs/remotes/origin/HEAD points to the now-deleted origin/main)
>>
>> I have a new patch that produces this:
>>
>> + git fetch --prune --dry-run
>> From /tmp/repo/.
>> - [deleted] (none) -> origin/branches
>> - [deleted] (none) -> origin/master
>> - [deleted] (none) -> origin/other
>> origin/HEAD will become dangling after origin/master is deleted
>>
>
>
> It is a bit weird that this says "will become dangling after <ref> is
> deleted" because the deletion already happened.
But that is with "--dry-run". Without it, presumably
origin/HEAD is now dangling since origin/master was deleted
or something, probably.
next prev parent reply other threads:[~2025-06-23 23:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 21:08 [RFC PATCH 0/2] fetch --prune performance problem Phil Hord
2025-06-18 21:08 ` [RFC PATCH 1/2] fetch-prune: optimize dangling-ref reporting Phil Hord
2025-06-18 21:50 ` Junio C Hamano
2025-06-18 23:18 ` Jacob Keller
2025-06-19 4:00 ` Jeff King
2025-06-19 11:01 ` Lidong Yan
2025-06-19 14:41 ` Lidong Yan
2025-06-18 21:08 ` [RFC PATCH 2/2] refs: remove old refs_warn_dangling_symref Phil Hord
2025-06-18 23:15 ` [RFC PATCH 0/2] fetch --prune performance problem Jacob Keller
2025-06-19 3:37 ` Jeff King
2025-06-19 17:18 ` Junio C Hamano
[not found] ` <CABURp0p4d0JPg=-cW1OZdFQJ+vNT_0PDd9Rv3oz6toFGqGv5=g@mail.gmail.com>
2025-06-23 23:32 ` Jacob Keller
2025-06-23 23:41 ` Junio C Hamano [this message]
[not found] ` <CABURp0q-1FGmD+PJeSQ=xvyDN6ZYn1O7Fh8i1OojfD2WQCqgcw@mail.gmail.com>
2025-06-23 23:46 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4iw63u1i.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=phil.hord@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox