public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Niels Glodny <n.glodny@campus•lmu.de>
Cc: phillip.wood@dunelm•org.uk,  git@vger•kernel.org,
	johannes.schindelin@gmx•de,  peff@peff•net
Subject: Re: [PATCH] xdiff: disable cleanup_records heuristic with --minimal
Date: Mon, 28 Apr 2025 10:05:17 -0700	[thread overview]
Message-ID: <xmqq4iy8dxo2.fsf@gitster.g> (raw)
In-Reply-To: <f3140b32-5a25-448b-a99c-1604f6237cb8@campus.lmu.de> (Niels Glodny's message of "Sun, 27 Apr 2025 23:44:21 +0200")

Niels Glodny <n.glodny@campus•lmu.de> writes:

> Hi Phillip,
>
> thank you for your detailed comments.
>
>> Have you got any numbers for the performance change?
>
> I have been using "git log -p -3000 --minimal > /dev/null", as in
> p4000-diff-algorithms.sh. With this patch, I get
>
>   Time (mean ± σ):      2.363 s ±  0.023 s (25 runs)
>
> Without this patch, I get
>
>   Time (mean ± σ):      2.362 s ±  0.035 s  (25 runs)
>
> So the difference is well within the margin of error. It doesn't
> look like it has any measurable impact on performance.

That is an excellent observation and result.  It should be added to
the proposed commit log message, if not already.  The commit log is
where you answer questions, similar to what were raised during
review by your reviewers, that future readers of "git log -p" would
have about your change.  For them you won't be easily available to
answer their questions, and that is why we stress on the need for
well-written commit log messages.

Thanks.

next prev parent reply	other threads:[~2025-04-28 17:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-25 15:59 [PATCH] xdiff: disable cleanup_records heuristic with --minimal Niels Glodny
2025-04-27 15:04 ` Phillip Wood
2025-04-27 21:44   ` Niels Glodny
2025-04-28 17:05     ` Junio C Hamano [this message]
2025-04-27 22:06 ` [PATCH v2] " Niels Glodny
2025-04-29  9:00   ` Phillip Wood
2025-04-29 14:09 ` [PATCH v3] " Niels Glodny
2025-05-06 13:21   ` Phillip Wood
2025-05-06 22:50     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4iy8dxo2.fsf@gitster.g \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=johannes.schindelin@gmx$(echo .)de \
    --cc=n.glodny@campus$(echo .)lmu.de \
    --cc=peff@peff$(echo .)net \
    --cc=phillip.wood@dunelm$(echo .)org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox