From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Rolf Eike Beer <eb@emlix•com>,
git@vger•kernel.org, Jaydeep P Das <jaydeepjd.8914@gmail•com>,
Hariom Verma <hariom18599@gmail•com>,
Christian Couder <chriscool@tuxfamily•org>
Subject: Re: [PATCH] gpg-interface: set trust level of missing key to "undefined"
Date: Mon, 24 Apr 2023 09:22:36 -0700 [thread overview]
Message-ID: <xmqq4jp5gshf.fsf@gitster.g> (raw)
In-Reply-To: <20230422104758.GA2969939@coredump.intra.peff.net> (Jeff King's message of "Sat, 22 Apr 2023 06:47:58 -0400")
Jeff King <peff@peff•net> writes:
> So before my patch the uninitialized state is (supposedly) less than the
> min level, and after they are the same. For the reasons I gave in the
> commit message, I think that less-than comparison was already broken.
> And likewise, for the reasons I gave, it hopefully never matters since
> the result would never be 'G' in that case.
Yes * 2.
> So I think it's fine, but I definitely had to stare at it for a while.
> This all comes from 54887b4689 (gpg-interface: add minTrustLevel as a
> configuration option, 2019-12-27), which does discuss some of the
> implications, but I think my patch is in line with the logic there.
Yes.
Thanks.
next prev parent reply other threads:[~2023-04-24 16:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 6:12 gpg-related crash with custom formatter (BUG: gpg-interface.c:915: invalid trust level requested -1) Rolf Eike Beer
2023-04-18 6:48 ` Jeff King
2023-04-18 15:16 ` Jaydeep Das
2023-04-18 16:24 ` Junio C Hamano
2023-04-19 1:29 ` [PATCH] gpg-interface: set trust level of missing key to "undefined" Jeff King
2023-04-19 15:30 ` Junio C Hamano
2023-04-22 10:47 ` Jeff King
2023-04-24 16:22 ` Junio C Hamano [this message]
2023-04-18 16:17 ` gpg-related crash with custom formatter (BUG: gpg-interface.c:915: invalid trust level requested -1) Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4jp5gshf.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=chriscool@tuxfamily$(echo .)org \
--cc=eb@emlix$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=hariom18599@gmail$(echo .)com \
--cc=jaydeepjd.8914@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox