From: Junio C Hamano <gitster@pobox•com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
Cc: Erik Cervin Edin <erik@cervined•in>,
Christian Couder <christian.couder@gmail•com>,
jurgen_gjoncari@icloud•com, git <git@vger•kernel.org>
Subject: Re: Make commit messages optional
Date: Mon, 11 Apr 2022 10:59:47 -0700 [thread overview]
Message-ID: <xmqq4k2zjyb0.fsf@gitster.g> (raw)
In-Reply-To: <220411.865ynfkj7r.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Mon, 11 Apr 2022 12:24:41 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail•com> writes:
> On Fri, Apr 08 2022, Erik Cervin Edin wrote:
>
>> At the risk of bikeshedding.
>>
>> The case in favor of not allowing empty commit messages by default is
>> that most of the time, empty commit messages are useless.
>>
>> I've written my fair share of poor commit messages (-,..., wip, foo).
>> Sometimes I've fixed that retroactively, sometimes not. The advantage
>> I see with empty commit messages is that it's more ubiquitous to
>> "write something better" or "whatever". The downside is I can't git
>> log --grep '^$' to find them.
>
> You can:
>
> git log --invert-grep --grep '.'
Wow, that's nasty.
In any case, "--allow-empty-messages" exists, and that is where we
draw the line. We will not bend over backwards beyond it.
Thanks.
next prev parent reply other threads:[~2022-04-11 18:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 3:35 Make commit messages optional jurgen_gjoncari
2022-04-08 8:02 ` Christian Couder
2022-04-08 11:26 ` Ævar Arnfjörð Bjarmason
2022-04-08 19:25 ` Erik Cervin Edin
2022-04-11 10:24 ` Ævar Arnfjörð Bjarmason
2022-04-11 17:59 ` Junio C Hamano [this message]
2022-04-11 18:18 ` Michal Suchánek
2022-04-11 21:09 ` Junio C Hamano
2022-04-08 8:15 ` Philip Oakley
2022-04-08 14:32 ` Phillip Susi
2022-04-08 22:30 ` brian m. carlson
2022-04-08 23:32 ` rsbecker
2022-04-09 11:32 ` Michal Suchánek
2022-04-10 13:59 ` Tao Klerks
2022-04-10 15:00 ` rsbecker
2022-04-10 15:18 ` rsbecker
2022-04-10 16:27 ` Tao Klerks
2022-04-13 5:40 ` Jonathan Nieder
2022-04-11 9:04 ` demerphq
2022-04-11 11:35 ` rsbecker
2022-04-11 10:19 ` Ævar Arnfjörð Bjarmason
2022-04-11 12:39 ` Tao Klerks
2022-04-11 18:09 ` Junio C Hamano
2022-04-11 18:15 ` Michal Suchánek
2022-04-11 18:23 ` tytso
2022-04-11 20:10 ` Ævar Arnfjörð Bjarmason
2022-04-14 14:46 ` Theodore Ts'o
2022-04-14 16:43 ` Ævar Arnfjörð Bjarmason
2022-04-14 17:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4k2zjyb0.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=avarab@gmail$(echo .)com \
--cc=christian.couder@gmail$(echo .)com \
--cc=erik@cervined$(echo .)in \
--cc=git@vger$(echo .)kernel.org \
--cc=jurgen_gjoncari@icloud$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox