Subject: Re: [PATCH 2/8] submodule: store new submodule commits oid_array in a struct

From: Junio C Hamano <[email-masked]>
Date: Thu, 10 Feb 2022 14:05:50 -0800

Jonathan Tan <[email-masked]> writes:

> Glen Choo <[email-masked]> writes:
>> +/*
>> + * Holds relevant information for a changed submodule. Used as the .util
>> + * member of the changed submodule string_list_item.
>> + */
>> +struct changed_submodule_data {
>> +	/* The submodule commits that have changed in the rev walk. */
>> +	struct oid_array *new_commits;
>> +};
>
> Overall this change is straightforward and looks good, except that I
> think that the struct oid_array can be embedded directly instead of
> through a pointer.

True.

I am a bit behind and haven't seen the simplicity 1/8 promised to
bring to us, but hopefully we'll see soon enough why 1/8 is a good
idea.