Subject: Re: [PATCH] refs: drop force_create argument of create_reflog API

From: Junio C Hamano <[email-masked]>
Date: Mon, 22 Nov 2021 11:00:57 -0800

"Han-Wen Nienhuys via GitGitGadget" <[email-masked]> writes:

> From: Han-Wen Nienhuys <[email-masked]>
>
> There is only one caller, builtin/checkout.c, and it hardcodes
> force_create=1.
>
> This argument was introduced in abd0cd3a301 (refs: new public ref function:
> safe_create_reflog, 2015-07-21), which promised to immediately use it in a
> follow-on commit, but that never happened.
>
> Signed-off-by: Han-Wen Nienhuys <[email-masked]>
> ---

Thanks.  It's an obvious simplification.  I wish all our changes were
like this ;-)

> diff --git a/t/helper/test-ref-store.c b/t/helper/test-ref-store.c
> index b314b81a45b..98f827edfb7 100644
> --- a/t/helper/test-ref-store.c
> +++ b/t/helper/test-ref-store.c
> @@ -181,11 +181,10 @@ static int cmd_reflog_exists(struct ref_store *refs, const char **argv)
>  static int cmd_create_reflog(struct ref_store *refs, const char **argv)
>  {
>  	const char *refname = notnull(*argv++, "refname");
> -	int force_create = arg_flags(*argv++, "force-create");
>  	struct strbuf err = STRBUF_INIT;
>  	int ret;
>  
> -	ret = refs_create_reflog(refs, refname, force_create, &err);
> +	ret = refs_create_reflog(refs, refname, &err);
>  	if (err.len)
>  		puts(err.buf);
>  	return ret;
> diff --git a/t/t1405-main-ref-store.sh b/t/t1405-main-ref-store.sh
> index 49718b7ea7f..c89cef2d26b 100755
> --- a/t/t1405-main-ref-store.sh
> +++ b/t/t1405-main-ref-store.sh
> @@ -108,7 +108,7 @@ test_expect_success 'delete_reflog(HEAD)' '
>  '
>  
>  test_expect_success 'create-reflog(HEAD)' '
> -	$RUN create-reflog HEAD 1 &&
> +	$RUN create-reflog HEAD &&
>  	git reflog exists HEAD
>  '
>  
> diff --git a/t/t1406-submodule-ref-store.sh b/t/t1406-submodule-ref-store.sh
> index 0a87058971e..f1e57a9c051 100755
> --- a/t/t1406-submodule-ref-store.sh
> +++ b/t/t1406-submodule-ref-store.sh
> @@ -92,7 +92,7 @@ test_expect_success 'delete_reflog() not allowed' '
>  '
>  
>  test_expect_success 'create-reflog() not allowed' '
> -	test_must_fail $RUN create-reflog HEAD 1
> +	test_must_fail $RUN create-reflog HEAD
>  '
>  
>  test_done
>
> base-commit: cd3e606211bb1cf8bc57f7d76bab98cc17a150bc