From: Junio C Hamano <gitster@pobox•com>
To: Bagas Sanjaya <bagasdotme@gmail•com>
Cc: git@vger•kernel.org, felipe.contreras@gmail•com,
"Ævar Arnfjörð Bjarmason" <avarab@gmail•com>,
"Emily Shaffer" <emilyshaffer@google•com>,
"Đoàn Trần Công Danh" <congdanhqx@gmail•com>,
"Eric Sunshine" <sunshine@sunshineco•com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx•de>
Subject: Re: [PATCH 2/2] make: delete strip target
Date: Thu, 26 Aug 2021 13:10:58 -0700 [thread overview]
Message-ID: <xmqq4kbcdl0t.fsf@gitster.g> (raw)
In-Reply-To: <20210826113824.50078-3-bagasdotme@gmail.com> (Bagas Sanjaya's message of "Thu, 26 Aug 2021 18:38:24 +0700")
Bagas Sanjaya <bagasdotme@gmail•com> writes:
> The target isn't needed anymore since stripping is done in install-strip
> target (in previous patch).
That is not a valid justification.
People's automation may have been using a perfectly valid
#!/bin/sh
make test &&
make doc &&
make strip &&
make install install-doc
and this patch will break them for no good reason.
We need to remember that just because we (think we) came up with a
better way does not necessarily mean that we can immediately force
our users to adopt the new way.
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail•com>
> ---
> Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index b8a3a64422..027b052a0c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2170,8 +2170,6 @@ please_set_SHELL_PATH_to_a_more_modern_shell:
>
> shell_compatibility_test: please_set_SHELL_PATH_to_a_more_modern_shell
>
> -strip: $(PROGRAMS) git$X
> - $(STRIP) $(STRIP_OPTS) $^
>
> ### Flags affecting all rules
prev parent reply other threads:[~2021-08-26 20:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 11:38 [PATCH 0/2] make: install stripped Git Bagas Sanjaya
2021-08-26 11:38 ` [PATCH 1/2] make: add install-stripped target Bagas Sanjaya
2021-08-26 20:08 ` Junio C Hamano
2021-08-27 7:57 ` Bagas Sanjaya
2021-08-27 12:41 ` Đoàn Trần Công Danh
2021-08-26 11:38 ` [PATCH 2/2] make: delete strip target Bagas Sanjaya
2021-08-26 19:36 ` Ævar Arnfjörð Bjarmason
2021-08-26 20:10 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4kbcdl0t.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=avarab@gmail$(echo .)com \
--cc=bagasdotme@gmail$(echo .)com \
--cc=congdanhqx@gmail$(echo .)com \
--cc=emilyshaffer@google$(echo .)com \
--cc=felipe.contreras@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox