From: Junio C Hamano <gitster@pobox•com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
Cc: Adam Dinwoodie <adam@dinwoodie•org>,
Git Mailing List <git@vger•kernel.org>
Subject: Re: Git v2.13.1 SHA1 very broken
Date: Tue, 06 Jun 2017 10:20:45 +0900 [thread overview]
Message-ID: <xmqq4lvtap3m.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CACBZZX6vOr+ZjUaAf8i1xdjEFfY_Exj+_Xn2-1u0RcWoLy+X1g@mail.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Mon, 5 Jun 2017 23:05:24 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail•com> writes:
> That looks scary, can you please comment out this:
>
> #define SHA1DC_ALLOW_UNALIGNED_ACCESS
>
> In sha1dc/sha1.c and see if that helps, alternatively comment out the
> ifdefs guarded by "#ifdef _MSC_VER" calls in sha1dc/sha1.c
That is merely a performance (and theoretical correctness) thing,
no?
> The functional differences between 2.13.0 and 2.13.1 on that platform
> should be none aside from possibly those changes, unless I've missed
> something.
If it does not hash correctly, the cause is more likely that the
endianness detection is going haywire.
make CFLAGS="-DSHA1DC_FORCE_LITTLEENDIAN -g -O2 -Wall"
or something like that, perhaps?
next prev parent reply other threads:[~2017-06-06 1:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 20:34 Git v2.13.1 SHA1 very broken Adam Dinwoodie
2017-06-05 21:05 ` Ævar Arnfjörð Bjarmason
2017-06-05 23:20 ` Ramsay Jones
2017-06-06 0:11 ` Ramsay Jones
2017-06-06 1:20 ` Junio C Hamano [this message]
2017-06-06 10:03 ` Adam Dinwoodie
2017-06-06 11:55 ` Junio C Hamano
2017-06-06 12:43 ` Adam Dinwoodie
2017-06-06 14:47 ` Continous Integration (was: RE: Git v2.13.1 SHA1 very broken) Jason Pyeron
2017-06-06 15:04 ` Lars Schneider
2017-07-02 20:35 ` Adam Dinwoodie
2017-07-03 12:34 ` Johannes Schindelin
2017-06-06 15:12 ` [PATCH 0/3] update sha1dc Ævar Arnfjörð Bjarmason
2017-06-06 15:12 ` [PATCH 1/3] sha1dc: update from upstream Ævar Arnfjörð Bjarmason
2017-06-06 15:12 ` [PATCH 2/3] sha1dc: optionally use sha1collisiondetection as a submodule Ævar Arnfjörð Bjarmason
2017-06-06 18:48 ` Stefan Beller
2017-06-06 19:03 ` Ævar Arnfjörð Bjarmason
2017-06-06 19:09 ` Stefan Beller
2017-06-06 15:12 ` [PATCH 3/3] sha1collisiondetection: automatically enable when submodule is populated Ævar Arnfjörð Bjarmason
2017-06-06 18:23 ` [PATCH 0/3] update sha1dc Stefan Beller
2017-06-06 18:51 ` Ævar Arnfjörð Bjarmason
2017-06-06 19:01 ` [PATCH] sha1dc: ignore indent-with-non-tab whitespace violations Jeff King
2017-06-06 19:04 ` Ævar Arnfjörð Bjarmason
2017-06-06 19:05 ` Stefan Beller
2017-06-13 2:09 ` [PATCH 0/3] update sha1dc Liam R. Howlett
2017-06-06 12:49 ` Git v2.13.1 SHA1 very broken Morten Welinder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4lvtap3m.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=adam@dinwoodie$(echo .)org \
--cc=avarab@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox