From: Junio C Hamano <gitster@pobox•com>
To: Michael J Gruber <git@grubix•eu>
Cc: git@vger•kernel.org, Ralf Thielow <ralf.thielow@googlemail•com>
Subject: Re: [PATCH v2 0/2] describe: localize debug output
Date: Mon, 27 Mar 2017 13:44:42 -0700 [thread overview]
Message-ID: <xmqq4lye1mbp.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <cover.1490633145.git.git@grubix.eu> (Michael J. Gruber's message of "Mon, 27 Mar 2017 18:50:04 +0200")
Michael J Gruber <git@grubix•eu> writes:
> v2 computes the width for the localized output dynamically.
> In fact, it might overcalculated a bit depending on the encoding,
> but this does not do any harm.
Thanks.
As you said, if we wanted to actually _align_, then it needs much
more work. But that is not what we are aiming for in this round,
it should be alright.
prev parent reply other threads:[~2017-03-27 20:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 15:12 [PATCH 1/2] describe: localize debug output fully Michael J Gruber
2017-03-17 15:12 ` [PATCH 2/2] l10n: de: translate describe debug terms Michael J Gruber
2017-03-17 18:17 ` [PATCH 1/2] describe: localize debug output fully Junio C Hamano
2017-03-27 16:50 ` [PATCH v2 0/2] describe: localize debug output Michael J Gruber
2017-03-27 16:50 ` [PATCH v2 1/2] describe: localize debug output fully Michael J Gruber
2017-03-27 16:50 ` [PATCH v2 2/2] l10n: de: translate describe debug terms Michael J Gruber
2017-03-27 20:44 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4lye1mbp.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@grubix$(echo .)eu \
--cc=git@vger$(echo .)kernel.org \
--cc=ralf.thielow@googlemail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox