From: Junio C Hamano <gitster@pobox•com>
To: Ivan Pozdeev <vano@mail•mipt.ru>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] comment for a long #ifdef
Date: Mon, 04 Apr 2016 10:54:18 -0700 [thread overview]
Message-ID: <xmqq4mbh5kfp.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <5701BCC1.9050306@mail.mipt.ru> (Ivan Pozdeev's message of "Mon, 4 Apr 2016 04:00:49 +0300")
Ivan Pozdeev <vano@mail•mipt.ru> writes:
> ---
> compat/poll/poll.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
As Eric pointed out, please sign-off your patch.
> diff --git a/compat/poll/poll.c b/compat/poll/poll.c
> index db4e03e..5eb0280 100644
> --- a/compat/poll/poll.c
> +++ b/compat/poll/poll.c
> @@ -441,7 +441,7 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)
> }
>
> return rc;
> -#else
> +#else /* #ifndef WIN32_NATIVE */
> static struct timeval tv0;
> static HANDLE hEvent;
> WSANETWORKEVENTS ev;
> @@ -622,5 +622,5 @@ restart:
> }
>
> return rc;
> -#endif
> +#endif /* #ifndef WIN32_NATIVE */
> }
> --
> 1.9.5.msysgit.1
There also is an #ifndef/#else/#endif in abspath.c that is larger
than a typical patch context; could you include a fix for that, too?
prev parent reply other threads:[~2016-04-04 17:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 1:00 [PATCH] comment for a long #ifdef Ivan Pozdeev
2016-04-04 1:54 ` Eric Sunshine
2016-04-04 17:23 ` Ivan Pozdeev
2016-04-04 17:54 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4mbh5kfp.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=vano@mail$(echo .)mipt.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox