From: Junio C Hamano <gitster@pobox•com>
To: Danny Lin <danny0838@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] contrib/subtree: fix linefeeds trimming for cmd_split()
Date: Tue, 05 May 2015 12:11:42 -0700 [thread overview]
Message-ID: <xmqq4mnqet5d.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAMbsUu6xZrMu_jrV=jR4XNLf1UXLApBiAWJiWJuKRb4xN90QJQ@mail.gmail.com> (Danny Lin's message of "Wed, 6 May 2015 01:20:08 +0800")
Danny Lin <danny0838@gmail•com> writes:
>> I think this was written knowing that "say" is merely a thin wrapper
>> of "echo" (which is a bad manner but happens to be correct) and
>> assuming that everybody's "echo" understands "-n" (which is not a
>> good assumption) to implement "progress display" that shows the "N
>> out of M done" output over and over on the same physical line.
>>
>> So,... contrary to your "makes no sense" claim, what it tries to do
>> makes perfect sense to me, even though its execution seems somewhat
>> poor.
>>
> The original version has a CR (yes, it's CR, not LF) at the end of the
> "say -n" string, which is weird. If it's meant to print a linefeed, we should
> remove the CR and use "say". If it's meant not to print a linefeed, we still
> should remove the CR.
Neither. It is meant to print a carriage-return, i.e. "go back to
the left-most column on the same line, without feeding a new line to
the terminal (causing the output to scroll-up by one line)".
It sounds to me that your terminal is not supporting carriage-return
in a way everybody else expects it to? It is not just this script,
but all the progress output we generate use CR for that purpose.
Do you see a similar "garbled" output from say "git fetch" or "git
checkout" that takes more than a few hundred milliseconds?
next prev parent reply other threads:[~2015-05-05 19:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 17:20 [PATCH] contrib/subtree: fix linefeeds trimming for cmd_split() Danny Lin
2015-05-05 19:11 ` Junio C Hamano [this message]
2015-05-06 9:57 ` Danny Lin
2015-05-06 17:16 ` Junio C Hamano
2015-05-06 18:58 ` Danny Lin
2015-05-06 19:49 ` Junio C Hamano
2015-05-06 19:58 ` Eric Sunshine
-- strict thread matches above, loose matches on Subject: below --
2015-05-07 3:39 Danny Lin
2015-05-07 3:43 ` Danny Lin
2015-05-07 5:10 ` Danny Lin
2015-05-07 18:33 ` Junio C Hamano
2015-05-04 6:13 Danny Lin
2015-05-04 21:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4mnqet5d.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=danny0838@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox