From: Junio C Hamano <gitster@pobox•com>
To: Vitor Antunes <vitor.hda@gmail•com>
Cc: git@vger•kernel.org, Luke Diamand <luke@diamand•org>
Subject: Re: [PATCH V2 1/2] t9801: check git-p4's branch detection and client view together
Date: Mon, 20 Apr 2015 15:45:15 -0700 [thread overview]
Message-ID: <xmqq4moaju6c.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <48EB5BF2-166D-45F5-9573-0C9E16CAC2B9@gmail.com> (Vitor Antunes's message of "Mon, 20 Apr 2015 23:25:17 +0100")
Vitor Antunes <vitor.hda@gmail•com> writes:
> On April 20, 2015 6:43:49 AM GMT+01:00, Junio C Hamano <gitster@pobox•com> wrote:
>>Vitor Antunes <vitor.hda@gmail•com> writes:
>>
>>> Add failing scenario where branch detection is enabled together with
>>> use client view. In this specific scenario git-p4 will break when the
>>> perforce client view removes part of the depot path.
>>
>>I somehow cannot parse "together with use client view", especially
>>the word "use". Is it "user client view" or something (I am not
>>familiar with p4 lingo), or perhaps "use of client view"?
>
> I meant "spec" instead of "view". As in - -use-client-spec.
>
> In perforce you need to configure your workspace using a client specification.
> One of the configured values is the client view, which maps files/folders in the
> server to locations in your local workspace. What I'm trying to fix with these
> patches is the ability of git-p4 to process the client view definition through
> the use of "p4 where" to determine the correct location of the local files, such
> that it is able to apply the necessary patches for submission to the perforce
> server.
>
> While thinking about client views I completely forgot that the git-p4 argument
> that enables thos feature uses "spec" and not "view".
So,... what's the conclusion? Should the log message be written
like this perhaps?
t9801: check git-p4's branch detection and client spec together
Add failing scenario where branch detection is enabled together
with use of client spec. In this specific scenario git-p4 will
break when the perforce client spec removes part of the depot
path.
The test case also includes an extra sub-file mapping to enforce
robustness check on git-p4 implementation.
Signed-off-by: Vitor Antunes <vitor.hda@gmail•com>
Signed-off-by: Junio C Hamano <gitster@pobox•com>
next prev parent reply other threads:[~2015-04-20 22:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-19 10:56 [PATCH V2 0/2] git-p4: improve client path detection with branches used Vitor Antunes
2015-04-19 10:56 ` [PATCH V2 1/2] t9801: check git-p4's branch detection and client view together Vitor Antunes
2015-04-20 5:43 ` Junio C Hamano
2015-04-20 22:25 ` Vitor Antunes
2015-04-20 22:45 ` Junio C Hamano [this message]
2015-04-21 7:10 ` Vitor Antunes
2015-04-19 10:56 ` [PATCH V2 2/2] git-p4: improve client path detection when branches are used Vitor Antunes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4moaju6c.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=luke@diamand$(echo .)org \
--cc=vitor.hda@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox