From: Junio C Hamano <gitster@pobox•com>
To: Michael J Gruber <git@drmicha•warpmail.net>
Cc: git@vger•kernel.org, Jeff King <peff@peff•net>,
Gunnar Wagner <gunnar.wagner@irisgermanica•com>
Subject: Re: [PATCH] commit: reword --author error message
Date: Thu, 15 Jan 2015 09:48:26 -0800 [thread overview]
Message-ID: <xmqq4mrs7x5h.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <84cf10a22858275d6e213311c93df7f6a5408f60.1421331608.git.git@drmicha.warpmail.net> (Michael J. Gruber's message of "Thu, 15 Jan 2015 15:23:08 +0100")
Michael J Gruber <git@drmicha•warpmail.net> writes:
> If an --author argument is specified but does not contain a '>' then git tries
> to find the argument within the exiting authors; and gives the error
> message "No existing author found with '%s'" if there is no match.
>
> This is confusing for users who try to specify a valid complete author
> name.
I suspect that you meant s/a valid/an invalid/, as if it is valid,
it cannot not contain '>' (after all, '>' is merely a rough
approximation to check if it is "Name <email>" format).
> Rename the error message to make it clearer that the failure has two
> reasons in this case:
> "Bad --author parameter '%s': neither completely wellformed nor part of
> an existing one"
You are trying to help a user who thought "Who www.where.com" was a
valid thing to pass to --author; "it is not completely wellformed"
is not very helpful without making her realize what in that bogus
string is not "completely well-formed".
Perhaps
"--author '%s' is not 'Name <email>' and no existing author matches that string"
or somesuch?
next prev parent reply other threads:[~2015-01-15 17:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 8:15 commit --amend --author error Gunnar Wagner
2015-01-13 11:24 ` Michael J Gruber
2015-01-14 12:09 ` Jeff King
2015-01-15 14:21 ` Michael J Gruber
2015-01-15 14:23 ` [PATCH] commit: reword --author error message Michael J Gruber
2015-01-15 14:25 ` Michael J Gruber
2015-01-15 14:31 ` Jeff King
2015-01-15 14:40 ` Michael J Gruber
2015-01-15 17:48 ` Junio C Hamano [this message]
2015-01-16 9:32 ` Jeff King
2015-01-16 17:29 ` Junio C Hamano
2015-01-16 18:33 ` Philip Oakley
2015-01-16 18:35 ` Junio C Hamano
2015-01-16 19:37 ` Eric Sunshine
2015-01-16 19:53 ` Junio C Hamano
2015-01-26 15:48 ` [PATCHv2] " Michael J Gruber
2015-01-26 19:07 ` Jeff King
2015-01-27 2:43 ` Junio C Hamano
2015-01-27 2:45 ` Jeff King
2015-01-27 8:37 ` Philip Oakley
2015-01-27 12:22 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4mrs7x5h.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@drmicha$(echo .)warpmail.net \
--cc=git@vger$(echo .)kernel.org \
--cc=gunnar.wagner@irisgermanica$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox