From: Junio C Hamano <gitster@pobox•com>
To: Stefan Beller <sbeller@google•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] date.c: phrase a comment gender neutral
Date: Tue, 18 Nov 2014 12:03:48 -0800 [thread overview]
Message-ID: <xmqq4mtwwa1n.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1416338668-30683-1-git-send-email-sbeller@google.com> (Stefan Beller's message of "Tue, 18 Nov 2014 11:24:28 -0800")
Stefan Beller <sbeller@google•com> writes:
> When looking for suitable functions to print dates,
> I found this gem. Let's make it gender neutral as
> nowadays people get upset by this gender debate.
For some time I used to use "she/her" on Mondays, Wednesdays and
Fridays and "he/his" on other days to balance them, and you are
seeing the artifact of that.
Some people might feel that we would be better off using "they" all
the time, but IMO it's such a minor thing that once it _is_ in the
tree, it's not really worth the patch noise to go and fix it up.
>
> Signed-off-by: Stefan Beller <sbeller@google•com>
> ---
> date.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/date.c b/date.c
> index 59dfe57..19fb439 100644
> --- a/date.c
> +++ b/date.c
> @@ -732,7 +732,7 @@ int parse_expiry_date(const char *date, unsigned long *timestamp)
> /*
> * We take over "now" here, which usually translates
> * to the current timestamp. This is because the user
> - * really means to expire everything she has done in
> + * really means to expire everything they have done in
> * the past, and by definition reflogs are the record
> * of the past, and there is nothing from the future
> * to be kept.
next prev parent reply other threads:[~2014-11-18 20:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 19:24 [PATCH] date.c: phrase a comment gender neutral Stefan Beller
2014-11-18 19:42 ` Jonathan Nieder
2014-11-18 20:03 ` Junio C Hamano [this message]
2014-11-18 20:07 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4mtwwa1n.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox