From: Junio C Hamano <gitster@pobox•com>
To: Christian Couder <chriscool@tuxfamily•org>
Cc: git@vger•kernel.org, johan@herland•net, josh@joshtriplett•org,
tr@thomasrast•ch, mhagger@alum•mit.edu, dan.carpenter@oracle•com,
greg@kroah•com, peff@peff•net, sunshine@sunshineco•com,
ramsay@ramsay1•demon.co.uk
Subject: Re: [PATCH v8 03/12] Move lower case functions into wrapper.c
Date: Thu, 27 Mar 2014 09:42:10 -0700 [thread overview]
Message-ID: <xmqq4n2jfva5.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140327.084745.2069840957131666658.chriscool@tuxfamily.org> (Christian Couder's message of "Thu, 27 Mar 2014 08:47:45 +0100 (CET)")
Christian Couder <chriscool@tuxfamily•org> writes:
> Yeah, but it seems a bit wasteful to allocate memory for a new string,
> then downcase it, then compare it with strcmp() and then free it,
> instead of just using strcasecmp() on the original string.
I wasn't looking at the caller (and I haven't). I agree that, if
you have to compare case-insensitive user input against known set of
tokens, using strcasecmp() would be saner than making a downcased
copy and the set of known tokens. I do not know however you want to
compare in a case-insensitive way in your application, though.
next prev parent reply other threads:[~2014-03-27 16:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 22:15 [PATCH v8 00/12] Add interpret-trailers builtin Christian Couder
2014-03-26 22:15 ` [PATCH v8 01/12] Add data structures and basic functions for commit trailers Christian Couder
2014-03-26 23:06 ` Junio C Hamano
2014-03-27 7:55 ` Christian Couder
2014-03-26 22:15 ` [PATCH v8 02/12] trailer: process trailers from stdin and arguments Christian Couder
2014-03-26 22:15 ` [PATCH v8 03/12] Move lower case functions into wrapper.c Christian Couder
2014-03-26 23:07 ` Junio C Hamano
2014-03-27 7:47 ` Christian Couder
2014-03-27 16:42 ` Junio C Hamano [this message]
2014-03-27 22:16 ` Junio C Hamano
2014-03-27 22:34 ` Jeff King
2014-03-27 22:47 ` Junio C Hamano
2014-03-27 22:56 ` Jeff King
2014-03-28 17:12 ` Junio C Hamano
2014-03-28 18:50 ` Jeff King
2014-03-28 7:02 ` Christian Couder
2014-03-26 22:15 ` [PATCH v8 04/12] trailer: read and process config information Christian Couder
2014-03-26 22:15 ` [PATCH v8 05/12] trailer: process command line trailer arguments Christian Couder
2014-03-26 22:15 ` [PATCH v8 06/12] trailer: parse trailers from stdin Christian Couder
2014-03-26 22:15 ` [PATCH v8 07/12] trailer: put all the processing together and print Christian Couder
2014-03-26 22:15 ` [PATCH v8 08/12] trailer: add interpret-trailers command Christian Couder
2014-03-26 22:15 ` [PATCH v8 09/12] trailer: add tests for "git interpret-trailers" Christian Couder
2014-03-26 22:15 ` [PATCH v8 10/12] trailer: execute command from 'trailer.<name>.command' Christian Couder
2014-03-26 22:15 ` [PATCH v8 11/12] trailer: add tests for commands in config file Christian Couder
2014-03-26 22:15 ` [PATCH v8 12/12] Documentation: add documentation for 'git interpret-trailers' Christian Couder
2014-03-26 23:05 ` [PATCH v8 00/12] Add interpret-trailers builtin Junio C Hamano
2014-03-27 7:53 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4n2jfva5.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=chriscool@tuxfamily$(echo .)org \
--cc=dan.carpenter@oracle$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=greg@kroah$(echo .)com \
--cc=johan@herland$(echo .)net \
--cc=josh@joshtriplett$(echo .)org \
--cc=mhagger@alum$(echo .)mit.edu \
--cc=peff@peff$(echo .)net \
--cc=ramsay@ramsay1$(echo .)demon.co.uk \
--cc=sunshine@sunshineco$(echo .)com \
--cc=tr@thomasrast$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox