public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Brian Gesiak <modocache@gmail•com>, git@vger•kernel.org
Subject: Re: [PATCH 2/2] branch: use skip_prefix
Date: Mon, 03 Mar 2014 11:54:32 -0800	[thread overview]
Message-ID: <xmqq4n3foy6f.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140228054613.GB32556@sigill.intra.peff.net> (Jeff King's message of "Fri, 28 Feb 2014 00:46:14 -0500")

Jeff King <peff@peff•net> writes:

> On Fri, Feb 28, 2014 at 12:04:19PM +0900, Brian Gesiak wrote:
>
>> From: modocache <modocache@gmail•com>
>
> Both your emailed patches have this, which is due to your author name
> not matching your sending identity. You probably want to set user.name,
> or if you already have (which it looks like you might have from your
> Signed-off-by), use "git commit --amend --reset-author" to update the
> author information.
>
>> The install_branch_config function reimplemented the skip_prefix
>> function inline. Use skip_prefix function instead for brevity.
>> 
>> Signed-off-by: Brian Gesiak <modocache@gmail•com>
>> Reported-by: Michael Haggerty <mhagger@alum•mit.edu>
>
> It's a minor thing, but usually these footer lines try to follow a
> chronological order. So the report would come before the signoff (and a
> further signoff from the maintainer would go after yours).
>
>> diff --git a/branch.c b/branch.c
>> index 723a36b..e163f3c 100644
>> --- a/branch.c
>> +++ b/branch.c
>> [...]
>
> The patch itself looks OK to me.
>
> -Peff

Thanks.  Queued and pushed out on 'pu' with fixups already.

next prev parent reply	other threads:[~2014-03-03 19:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28  3:04 [PATCH 1/2] t3200-branch: test setting branch as own upstream Brian Gesiak
2014-02-28  3:04 ` [PATCH 2/2] branch: use skip_prefix Brian Gesiak
2014-02-28  5:46   ` Jeff King
2014-03-03 19:54     ` Junio C Hamano [this message]
2014-02-28  5:37 ` [PATCH 1/2] t3200-branch: test setting branch as own upstream Jeff King
2014-02-28  6:17   ` Brian Gesiak
2014-02-28  6:27     ` Jeff King
2014-02-28 22:15       ` brian m. carlson
2014-02-28  6:55   ` Johannes Sixt
2014-02-28  7:14     ` Jeff King
2014-02-28  7:26       ` Jeff King
2014-02-28  7:28         ` Brian Gesiak
2014-02-28  8:37           ` Jeff King
2014-02-28 10:44             ` Brian Gesiak
2014-02-28 10:59               ` Jeff King
2014-02-28 11:16                 ` Brian Gesiak
2014-02-28 13:03                   ` Jeff King
2014-02-28 14:57                     ` Matthieu Moy
2014-03-01 12:19                       ` [PATCH v2] branch: die when " Brian Gesiak
2014-03-01 12:23                         ` [PATCH 3/3] " Brian Gesiak
2014-03-01 12:26                           ` Brian Gesiak
2014-02-28  7:40       ` [PATCH 1/2] t3200-branch: test " Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4n3foy6f.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=modocache@gmail$(echo .)com \
    --cc=peff@peff$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox