public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Michael Haggerty <mhagger@alum•mit.edu>,
	git discussion list <git@vger•kernel.org>,
	Martin von Zweigbergk <martin.von.zweigbergk@gmail•com>,
	Johannes Schindelin <johannes.schindelin@gmx•de>
Subject: Re: GSoC idea: allow "git rebase --interactive" todo lines to take options
Date: Wed, 26 Feb 2014 11:55:20 -0800	[thread overview]
Message-ID: <xmqq4n3l4pjr.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140226105249.GE25711@sigill.intra.peff.net> (Jeff King's message of "Wed, 26 Feb 2014 05:52:49 -0500")

Jeff King <peff@peff•net> writes:

> On Wed, Feb 26, 2014 at 09:04:30AM +0100, Michael Haggerty wrote:
>
>> It would be nice to support more flexibility in the todo-list commands
>> by allowing the commands to take options.  Maybe
>> 
>> * Convert a commit into a merge commit:
>> 
>>       pick -p c0ffeee -p e1ee712 deadbab The oneline of the commit after
>
> This seems like a reasonable feature to me. All of your examples are
> possible with an "e"dit and another git command, but the convenience may
> be worth it (though personally, most of the examples you gave are
> particularly interesting to me[1]).

I actually had a completely opposite reaction to the above one.  It
took considerable mental effort to decipher what that "pick -p ..."
line was trying to do, and I am not absolutely sure if I understand
what it is trying to do enough to rewrite it to an equivalent
"inconvenient" sequence of "edit and another git command".

> [1] The one feature I would like in this vein is that editing the title
>     in the instruction-sheet would modify the commit message of the
>     relevant commit. For some reason I try to do this every few weeks,
>     but of course the changes are just thrown away.

Every time I thought about this one, I get stopped after realizing
that the title line is only a small part of the log message.

  parent reply	other threads:[~2014-02-26 19:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-26  8:04 GSoC idea: allow "git rebase --interactive" todo lines to take options Michael Haggerty
2014-02-26 10:52 ` Jeff King
2014-02-26 11:14   ` Michael Haggerty
2014-02-26 11:42     ` Jeff King
2014-02-26 14:55   ` Tay Ray Chuan
2014-02-26 19:55   ` Junio C Hamano [this message]
2014-02-27  7:48   ` Michael Haggerty
2014-02-27 18:10   ` Brandon McCaig
2014-02-28 12:52     ` Jeff King
2014-02-28 14:03       ` Michael Haggerty
2014-03-11  1:37         ` Jeff King
2014-03-11 19:31           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4n3l4pjr.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=johannes.schindelin@gmx$(echo .)de \
    --cc=martin.von.zweigbergk@gmail$(echo .)com \
    --cc=mhagger@alum$(echo .)mit.edu \
    --cc=peff@peff$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox