public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Christian Couder <christian.couder@gmail•com>
Cc: Christian Couder <chriscool@tuxfamily•org>,
	git <git@vger•kernel.org>, Johan Herland <johan@herland•net>,
	Josh Triplett <josh@joshtriplett•org>,
	Thomas Rast <tr@thomasrast•ch>,
	Michael Haggerty <mhagger@alum•mit.edu>,
	Dan Carpenter <dan.carpenter@oracle•com>,
	Greg Kroah-Hartman <greg@kroah•com>
Subject: Re: [RFC/PATCH] Add interpret-trailers builtin
Date: Wed, 06 Nov 2013 09:18:12 -0800	[thread overview]
Message-ID: <xmqq4n7pa1pn.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAP8UFD0STna++2StV1RcT2bB83Lh_hFQU94A0y4ziovs61Z==A@mail.gmail.com> (Christian Couder's message of "Wed, 6 Nov 2013 10:23:24 +0100")

Christian Couder <christian.couder@gmail•com> writes:

> To append a s-o-b only if there is no s-o-b already, one would need to use:
>
> [trailer "signoff"]
>          key = "Signed-off-by:"
>          if_exist = dont_append
>          if_missing = append
>          command = echo "$GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL>"'

But that is insufficient to emulate what we do, no?  I.e. append
unless the last one is from the same person we are about to add.

  reply	other threads:[~2013-11-06 17:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-03 21:17 [RFC/PATCH] Add interpret-trailers builtin Christian Couder
2013-11-04  1:01 ` Johan Herland
2013-11-04 19:12   ` Junio C Hamano
2013-11-05  2:45     ` Johan Herland
2013-11-05  5:42       ` Christian Couder
2013-11-05 19:09       ` Junio C Hamano
2013-11-04 19:02 ` Junio C Hamano
2013-11-06  6:43   ` Christian Couder
2013-11-06  9:23     ` Christian Couder
2013-11-06 17:18       ` Junio C Hamano [this message]
2013-11-06 20:16         ` Christian Couder
2013-11-06 20:42           ` Junio C Hamano
2013-11-07 14:57             ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4n7pa1pn.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=chriscool@tuxfamily$(echo .)org \
    --cc=christian.couder@gmail$(echo .)com \
    --cc=dan.carpenter@oracle$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=greg@kroah$(echo .)com \
    --cc=johan@herland$(echo .)net \
    --cc=josh@joshtriplett$(echo .)org \
    --cc=mhagger@alum$(echo .)mit.edu \
    --cc=tr@thomasrast$(echo .)ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox