From: Junio C Hamano <gitster@pobox•com>
To: Nicolas Vigier <boklm@mars-attacks•org>
Cc: git@vger•kernel.org, Pierre Habouzit <madcoder@debian•org>
Subject: Re: [PATCH] rev-parse --parseopt: fix handling of optional arguments
Date: Tue, 15 Oct 2013 15:55:36 -0700 [thread overview]
Message-ID: <xmqq4n8ib0uv.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: 1381838425-18244-1-git-send-email-boklm@mars-attacks.org
Nicolas Vigier <boklm@mars-attacks•org> writes:
> git rev-parse --parseopt does not allow us to see the difference
> between an option with an optional argument starting with a dash, and an
> option with an unset optional argument followed by an other option.
>
> If I use this script :
>
> $ cat /tmp/opt.sh
> #!/bin/sh
> OPTIONS_SPEC="\
> git [options]
> --
> q,quiet be quiet
> S,gpg-sign? GPG-sign commit"
> echo "$OPTIONS_SPEC" | git rev-parse --parseopt $parseopt_extra -- "$@"
>
> Then the following two commands give us the same result :
>
> $ /tmp/opt.sh -S -q
> set -- -S -q --
> $ /tmp/opt.sh -S-q
> set -- -S '-q' --
>
> We cannot know if '-q' is an argument to '-S' or a new option.
>
> With this patch, rev-parse --parseopt will always give an argument to
> optional options, as an empty string if the argument is unset.
>
> The same two commands now give us :
>
> $ /tmp/opt.sh -S -q
> set -- -S '' -q --
> $ /tmp/opt.sh -S-q
> set -- -S '-q' --
Two are different, but the former "set -- -S '' -q --" is not what
you want, either, no? -S with an explicit empty argument and -S
alone without argument may mean two totally different things, which
is the whole point of "option with an optional parameter". If some
code that have been using "rev-parse --parseopt" was happy with
$ /tmp/opt.sh -S
set -- -S --
and then your updated version gave it this instead:
$ /tmp/opt.sh -S
set -- -S '' --
wouldn't it be a regression to them?
next prev parent reply other threads:[~2013-10-15 22:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 12:00 [PATCH] rev-parse --parseopt: fix handling of optional arguments Nicolas Vigier
2013-10-15 22:55 ` Junio C Hamano [this message]
2013-10-15 23:47 ` Nicolas Vigier
2013-10-15 23:14 ` Jonathan Nieder
2013-10-15 23:33 ` Junio C Hamano
2013-10-15 23:57 ` Jonathan Nieder
2013-10-16 7:04 ` Johannes Sixt
2013-10-16 8:53 ` Jeff King
2013-10-16 21:40 ` Junio C Hamano
2013-10-16 21:50 ` Jeff King
2013-10-16 10:58 ` Nicolas Vigier
2013-10-16 14:14 ` Nicolas Vigier
2013-10-16 22:33 ` Jonathan Nieder
2013-10-25 20:18 ` [PATCH] rev-parse --parseopt: add the --sticked-long mode Nicolas Vigier
2013-10-25 22:01 ` Junio C Hamano
2013-10-25 22:52 ` Nicolas Vigier
2013-10-25 22:55 ` Junio C Hamano
2013-10-26 21:55 ` Philip Oakley
2013-10-28 15:47 ` Junio C Hamano
2013-10-31 11:08 ` sticked -> stuck Nicolas Vigier
2013-10-31 11:08 ` [PATCH 1/2] Use the word 'stuck' instead of 'sticked' Nicolas Vigier
2013-10-31 19:35 ` Junio C Hamano
2013-10-31 11:08 ` [PATCH 2/2] rev-parse --parseopt: add the --stuck-long mode Nicolas Vigier
2013-10-27 5:45 ` [PATCH] rev-parse --parseopt: add the --sticked-long mode Michael Haggerty
2013-10-15 23:53 ` [PATCH] rev-parse --parseopt: fix handling of optional arguments Nicolas Vigier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4n8ib0uv.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=boklm@mars-attacks$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=madcoder@debian$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox