From: Junio C Hamano <gitster@pobox•com>
To: Sebastian Schuberth <sschuberth@gmail•com>
Cc: git@vger•kernel.org, Karsten Blees <karsten.blees@gmail•com>
Subject: Re: [PATCH] Windows: Do not redefine _WIN32_WINNT
Date: Wed, 11 Sep 2013 11:29:14 -0700 [thread overview]
Message-ID: <xmqq4n9rtdol.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <52309507.1090908@gmail.com> (Sebastian Schuberth's message of "Wed, 11 Sep 2013 18:06:31 +0200")
Sebastian Schuberth <sschuberth@gmail•com> writes:
> diff --git a/git-compat-util.h b/git-compat-util.h
> index 664305c..f5c756d 100644
> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -93,7 +93,9 @@
> #undef __NO_INLINE__
>
> #ifdef WIN32 /* Both MinGW and MSVC */
> +#ifndef _WIN32_WINNT
> #define _WIN32_WINNT 0x0502
> +#endif
> #define WIN32_LEAN_AND_MEAN /* stops windows.h including winsock.h */
> #include <winsock2.h>
> #include <windows.h>
This unfortunately does not seem to match what I have. I think the
patch is based on the codebase before these two:
380395d0 (mingw: rename WIN32 cpp macro to GIT_WINDOWS_NATIVE, 2013-05-02)
41f29991 (msvc: Fix compilation errors caused by poll.h emulation, 2013-01-31)
I could of course wiggle it in, if you want, but I wanted to know
what is going on. Is it a pre-release freeze period on your side or
something?
next prev parent reply other threads:[~2013-09-11 18:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 16:06 [PATCH] Windows: Do not redefine _WIN32_WINNT Sebastian Schuberth
2013-09-11 18:29 ` Junio C Hamano [this message]
2013-09-11 20:03 ` Sebastian Schuberth
2013-09-11 21:51 ` Junio C Hamano
2013-09-12 8:41 ` Sebastian Schuberth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4n9rtdol.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=karsten.blees@gmail$(echo .)com \
--cc=sschuberth@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox