From: Junio C Hamano <junio@pobox•com>
To: Pete Wyckoff <pw@padd•com>
Cc: Stefano Lattarini <stefano.lattarini@gmail•com>,
Sverre Rabbelier <srabbelier@gmail•com>,
git@vger•kernel.org, Clemens Buchacher <drizzd@aon•at>
Subject: Re: [PATCHv2] git-remote-testgit: fix race when spawning fast-import
Date: Sun, 22 Apr 2012 19:40:59 -0700 [thread overview]
Message-ID: <xmqq4nsbmapw.fsf@junio.mtv.corp.google.com> (raw)
In-Reply-To: <20120422203058.GA17290@padd.com> (Pete Wyckoff's message of "Sun, 22 Apr 2012 16:30:58 -0400")
Pete Wyckoff <pw@padd•com> writes:
> Clemens suggested disabling the test by default, as I've done
> here. I think it would be okay to remove it entirely, too.
Ok.
> +# Generally, skip this test. It demonstrates a now-fixed
> +# race in git-remote-testgit, but is too slow to leave in
> +# for general use.
> +test_expect_success DEBUG_TESTGIT_RACE 'racily pushing to local repo' '
> + cp -a server server2 &&
> + git clone "testgit::${PWD}/server2" localclone2 &&
> + test_when_finished "rm -rf server2 localclone2" &&
Shouldn't test_when_finished come before these two commands? Otherwise
server2 or localclone2 directories will be left behind when they fail
before control reaches it...
next prev parent reply other threads:[~2012-04-23 2:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-14 9:01 master: t5800-remote-helpers.sh hangs on test "pulling from remote remote" Stefano Lattarini
2012-04-14 20:14 ` Clemens Buchacher
2012-04-15 0:00 ` Stefano Lattarini
2012-04-15 1:11 ` Clemens Buchacher
2012-04-15 8:08 ` Stefano Lattarini
2012-04-15 10:59 ` Clemens Buchacher
2012-04-15 11:18 ` Stefano Lattarini
2012-04-15 11:45 ` Clemens Buchacher
2012-04-15 11:58 ` Stefano Lattarini
2012-04-15 12:09 ` Clemens Buchacher
2012-04-15 13:19 ` Stefano Lattarini
2012-04-15 12:51 ` Clemens Buchacher
2012-04-17 1:46 ` Sverre Rabbelier
2012-04-19 23:34 ` Pete Wyckoff
[not found] ` <4F9145A1.6020201@gmail.com>
2012-04-21 20:15 ` Pete Wyckoff
2012-04-21 23:35 ` Clemens Buchacher
2012-04-22 2:17 ` Pete Wyckoff
2012-04-21 23:45 ` [PATCH] git-remote-testgit: fix race when spawning fast-import Pete Wyckoff
2012-04-21 23:42 ` Clemens Buchacher
2012-04-22 2:16 ` Pete Wyckoff
2012-04-22 9:49 ` Clemens Buchacher
2012-04-22 4:50 ` Junio C Hamano
2012-04-22 20:30 ` [PATCHv2] " Pete Wyckoff
2012-04-23 2:40 ` Junio C Hamano [this message]
2012-04-23 11:35 ` Pete Wyckoff
2012-04-15 11:12 ` master: t5800-remote-helpers.sh hangs on test "pulling from remote remote" Stefano Lattarini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4nsbmapw.fsf@junio.mtv.corp.google.com \
--to=junio@pobox$(echo .)com \
--cc=drizzd@aon$(echo .)at \
--cc=git@vger$(echo .)kernel.org \
--cc=pw@padd$(echo .)com \
--cc=srabbelier@gmail$(echo .)com \
--cc=stefano.lattarini@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox