From: Junio C Hamano <gitster@pobox•com>
To: "René Scharfe" <l.s.r@web•de>
Cc: "Git List" <git@vger•kernel.org>, "Rubén Justo" <rjusto@gmail•com>
Subject: Re: [PATCH] add-patch: fully document option P
Date: Tue, 21 Oct 2025 14:36:58 -0700 [thread overview]
Message-ID: <xmqq5xc8szr9.fsf@gitster.g> (raw)
In-Reply-To: <0188c766-d788-476d-a4d4-f95a6f59b31b@web.de> ("René Scharfe"'s message of "Tue, 21 Oct 2025 20:02:53 +0200")
René Scharfe <l.s.r@web•de> writes:
> Show option P in the prompt and explain it properly on a dedicated line
> in online help and documentation.
>
> Signed-off-by: René Scharfe <l.s.r@web•de>
> ---
> Documentation/git-add.adoc | 1 +
> add-patch.c | 5 +++--
> t/t3701-add-interactive.sh | 44 +++++++++++++++++++-------------------
> 3 files changed, 26 insertions(+), 24 deletions(-)
Nice. I do not recall why we decided to hide "P" behind "p" like
this, but I think making it clear like this patch does does make
sense.
prev parent reply other threads:[~2025-10-21 21:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 18:02 [PATCH] add-patch: fully document option P René Scharfe
2025-10-21 21:36 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5xc8szr9.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=l.s.r@web$(echo .)de \
--cc=rjusto@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox