Subject: Re: [GSoC PATCH v4 0/2] repo: add -z and objects.format

From: Junio C Hamano <[email-masked]>
Date: Thu, 04 Sep 2025 11:40:02 -0700

Lucas Seiki Oshiro <[email-masked]> writes:

> This v4 fixes two codestyle issues:
>
> - Break line before opening a brace
> - Add spaces surrounding a `|`

Looks good.  THese are the only things

    $ git clang-format --diff HEAD~2 HEAD

reports on the version that has been in my tree.

Will queue; let's mark it for 'next'.

>
> Here's the range-diff versus v3:
>
> 1:  0323f1fa75 ! 1:  19c84e1a48 repo: add the flag -z as an alias for --format=nul
>     @@ builtin/repo.c: static int print_fields(int argc, const char **argv,
>       }
>
>      +static int parse_format_cb(const struct option *opt,
>     -+                     const char *arg, int unset UNUSED) {
>     ++                     const char *arg, int unset UNUSED)
>     ++{
>      +  enum output_format *format = opt->value;
>      +
>      +  if (opt->short_name == 'z')
>     @@ builtin/repo.c: static int print_fields(int argc, const char **argv,
>      +                         PARSE_OPT_NONEG, parse_format_cb),
>      +          OPT_CALLBACK_F('z', NULL, &format, NULL,
>      +                         N_("synonym for --format=nul"),
>     -+                         PARSE_OPT_NONEG|PARSE_OPT_NOARG,
>     ++                         PARSE_OPT_NONEG | PARSE_OPT_NOARG,
>      +                         parse_format_cb),
>                 OPT_END()
>         };
> 2:  b2b241f401 = 2:  6258316d93 repo: add the field objects.format
>
> Lucas Seiki Oshiro (2):
>   repo: add the flag -z as an alias for --format=nul
>   repo: add the field objects.format
>
>  Documentation/git-repo.adoc |  9 ++++++--
>  builtin/repo.c              | 45 +++++++++++++++++++++++++++----------
>  t/t1900-repo.sh             | 18 +++++++++++++++
>  3 files changed, 58 insertions(+), 14 deletions(-)