Subject: Re: [GSoC][PATCH v2] t: migrate helper/test-oidmap.c to unit-tests/t-oidmap.c

From: Junio C Hamano <[email-masked]>
Date: Tue, 02 Jul 2024 11:55:14 -0700

Phillip Wood <[email-masked]> writes:

>> +	}
> 	check_int(count, ARRAY_SIZE(key_val));
>
> to check that we iterate over all the entries as well as checking the
> size of the hashmap here.

I think check_int() macro wants the comparison operator in the
middle, but other than that small typo, the suggestion sounds quite
sensible.  If the iterator does not yield anything, the current test
would still pass.

Thanks.