From: Junio C Hamano <gitster@pobox•com>
To: "Leslie Cheng via GitGitGadget" <gitgitgadget@gmail•com>
Cc: git@vger•kernel.org, Eric Wong <e@80x24•org>,
Leslie Cheng <leslie.cheng5@gmail•com>,
Leslie Cheng <leslie@lc•fyi>
Subject: Re: [PATCH v2] Add unix domain socket support to HTTP transport
Date: Fri, 23 Feb 2024 07:43:31 -0800 [thread overview]
Message-ID: <xmqq5xyfyyn0.fsf@gitster.g> (raw)
In-Reply-To: <xmqqzfvrzic9.fsf@gitster.g> (Junio C. Hamano's message of "Fri, 23 Feb 2024 00:37:58 -0800")
Junio C Hamano <gitster@pobox•com> writes:
> "Leslie Cheng via GitGitGadget" <gitgitgadget@gmail•com> writes:
>
>> Subject: Re: [PATCH v2] Add unix domain socket support to HTTP transport
>
> Perhaps
>
> Subject: [PATCH] http: enable proxying via unix-domain socket
>
> to follow the usual "<area>: <description>" format?
>
>> From: Leslie Cheng <leslie.cheng5@gmail•com>
>>
>> This changeset introduces an `http.unixSocket` option so that users can
>
> "This changeset introduces" -> "Introduce". There may be other
> gotchas that might use help from Documentation/SubmittingPatches,
> but I didn't read too carefully.
>
> Besides, it is a single patch, not a set of changes ;-).
>
> `http.unixSocket` is a configuration variable. It may be confusing
> to use the word "option". Speaking of options, shouldn't there be a
> command line option that overrides the configured value?
>
> We should honor the usual http.<url>.VARIABLE convention where
> http.<url>.VARIABLE that is destination-specific overrides a more
> generic http.VARIABLE configuration variable.
Clarification. I know the above is automatically achieved, given
the way we have laid urlmatch foundation to allow easy parsing for
configuration variables structured this way. I did not mean that
you'd need to do anything special; rather, I meant that we should
advertise that we do in the commit log message.
next prev parent reply other threads:[~2024-02-23 15:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 9:14 [PATCH] Add unix domain socket support to HTTP transport Leslie Cheng via GitGitGadget
2024-02-21 22:09 ` Eric Wong
2024-02-22 3:04 ` Leslie Cheng
2024-02-23 1:58 ` [PATCH v2] " Leslie Cheng via GitGitGadget
2024-02-23 8:37 ` Junio C Hamano
2024-02-23 15:43 ` Junio C Hamano [this message]
2024-02-23 22:24 ` Leslie Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5xyfyyn0.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=e@80x24$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=leslie.cheng5@gmail$(echo .)com \
--cc=leslie@lc$(echo .)fyi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox