Subject: Re: [PATCH 12/15] gettext tests: don't ignore "test-tool regex" exit code

From: Junio C Hamano <[email-masked]>
Date: Wed, 02 Mar 2022 15:20:51 -0800

Ævar Arnfjörð Bjarmason  <[email-masked]> writes:

> -test_have_prereq GETTEXT_LOCALE &&
> -test-tool regex "HALLÓ" "Halló" ICASE &&
> -test_set_prereq REGEX_LOCALE
> +test_expect_success GETTEXT_LOCALE 'setup REGEX_LOCALE prerequisite' '
> +	if test-tool regex "HALLÓ" "Halló" ICASE
> +	then
> +		test_set_prereq REGEX_LOCALE

This looks sensible but

> +	else
> +		test_must_fail test-tool regex "HALLÓ" "Halló" ICASE

this side looks puzzling.  I think this way to avoid counting abort
etc as passing "must fail" test would be the least bad that we can
do.

Nicely done.

> +	fi
> +'