public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: "Robin Jarry" <robin@jarry•cc>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>,
	git@vger•kernel.org,
	"Nicolas Dichtel" <nicolas.dichtel@6wind•com>,
	"Jan Smets" <jan.smets@nokia•com>,
	"Stephen Morton" <stephen.morton@nokia•com>,
	"Jeff King" <peff@peff•net>
Subject: Re: [PATCH v2] receive-pack: ignore SIGPIPE while reporting status to client
Date: Tue, 09 Nov 2021 15:03:12 -0800	[thread overview]
Message-ID: <xmqq5yt10w5r.fsf@gitster.g> (raw)
In-Reply-To: <CFLKOIVJ8EX0.2PWQ6PCXZ340A@diabtop> (Robin Jarry's message of "Tue, 09 Nov 2021 22:38:45 +0100")

"Robin Jarry" <robin@jarry•cc> writes:

>> > +		sigchain_push(SIGPIPE, SIG_IGN);
>> >  		if (pack_lockfile)
>> >  			unlink_or_warn(pack_lockfile);
>>
>> Shouldn't we start ignoring SIGPIPE here, not before we try to
>> unlink the lockfile?
>
> I initially wanted to avoid getting SIGPIPE'd while printing a warning
> if the lockfile cannot be unlinked. Maybe this means the repository
> integrity is compromised and we are well beyond ensuring post-receive is
> executed or not. I do not know git internals well enough to be sure.
>
> What do you think?

I think that push/pop pair should surround the part that reports the
status, as the proposed commit log message said.

Thanks.

next prev parent reply	other threads:[~2021-11-09 23:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04 13:35 [RFC PATCH] receive-pack: run post-receive before reporting status Robin Jarry
2021-11-06  5:03 ` Ævar Arnfjörð Bjarmason
2021-11-06 21:32   ` Robin Jarry
2021-11-06 22:03 ` [PATCH v2] receive-pack: ignore SIGPIPE while reporting status to client Robin Jarry
2021-11-09 21:10   ` Junio C Hamano
2021-11-09 21:38     ` Robin Jarry
2021-11-09 23:03       ` Junio C Hamano [this message]
2021-11-10 10:35     ` [RFC PATCH] receive-pack: interrupt pre-receive when client disconnects Robin Jarry
2021-12-29 14:21       ` Robin Jarry
2021-11-10  9:29   ` [PATCH v3] receive-pack: ignore SIGPIPE while reporting status to client Robin Jarry
2021-11-18  9:36     ` Robin Jarry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5yt10w5r.fsf@gitster.g \
    --to=gitster@pobox$(echo .)com \
    --cc=avarab@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=jan.smets@nokia$(echo .)com \
    --cc=nicolas.dichtel@6wind$(echo .)com \
    --cc=peff@peff$(echo .)net \
    --cc=robin@jarry$(echo .)cc \
    --cc=stephen.morton@nokia$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox