Subject: Re: [RFC PATCH] fast-export, fast-import: Let tags specify an internal name

From: Junio C Hamano <[email-masked]>
Date: Wed, 21 Apr 2021 10:48:56 -0700

Ævar Arnfjörð Bjarmason <[email-masked]> writes:

>> +	tagname = memmem(buf, message ? message - buf : size, "\ntag ", 5);
>> +	if (!tagname)
>> +		die("malformed tag %s", oid_to_hex(&tag->object.oid));
>> +	tagname += 5;
>> +	tagname_end = strchrnul(tagname, '\n');
>
> So it's no longer possible to export a reporitory with a missing "tag"
> entry in a tag? Maybe OK, but we have an escape hatch for it with fsck,
> we don't need one here?

We do have an escape hatch for missing "tagger" (e.g. "git cat-file
tag v0.99") in tag.c::parse_tag_buffer() that is used by fsck.

But a missing "tag " gets an immediate "return -1".