From: Junio C Hamano <gitster@pobox•com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] dir.c: avoid stat() in valid_cached_dir()
Date: Thu, 28 Dec 2017 11:10:42 -0800 [thread overview]
Message-ID: <xmqq608qllcd.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqd12yllkz.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Thu, 28 Dec 2017 11:05:32 -0800")
Junio C Hamano <gitster@pobox•com> writes:
>> [1] https://public-inbox.org/git/CACsJy8AmbKSp0mDLRaDCWn45veeNc03B-Gq8r8PQPrDt9bM_EA@mail.gmail.com/
>>
>> dir.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/dir.c b/dir.c
>> index 7c4b45e30e..edcb7bb462 100644
>> --- a/dir.c
>> +++ b/dir.c
>> @@ -1809,7 +1809,7 @@ static int valid_cached_dir(struct dir_struct *dir,
>> */
>> refresh_fsmonitor(istate);
>> if (!(dir->untracked->use_fsmonitor && untracked->valid)) {
>> - if (stat(path->len ? path->buf : ".", &st)) {
>> + if (lstat(path->len ? path->buf : ".", &st)) {
Hmph, I have to wonder if this is sufficient, though. When you got
"a/b/c" in path->buf, is it sufficient to avoid mistaking 'c' that
is (eh, rather, "has unexpectedly turned into") a symbolic link to a
directory as a true directory? Wouldn't we have to be equally careful
about "a" and "a/b" as well?
>> invalidate_directory(dir->untracked, untracked);
>> memset(&untracked->stat_data, 0, sizeof(untracked->stat_data));
>> return 0;
next prev parent reply other threads:[~2017-12-28 19:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-28 0:28 [PATCH] dir.c: avoid stat() in valid_cached_dir() Nguyễn Thái Ngọc Duy
2017-12-28 19:05 ` Junio C Hamano
2017-12-28 19:10 ` Junio C Hamano [this message]
2018-01-01 23:57 ` Duy Nguyen
2018-01-03 20:49 ` [PATCH v2 0/5] untracked cache bug fixes Ævar Arnfjörð Bjarmason
2018-01-03 20:49 ` [PATCH v2 1/5] status: add a failing test showing a core.untrackedCache bug Ævar Arnfjörð Bjarmason
2018-01-03 20:49 ` [PATCH v2 2/5] dir.c: avoid stat() in valid_cached_dir() Ævar Arnfjörð Bjarmason
2018-01-03 20:49 ` [PATCH v2 3/5] dir.c: fix missing dir invalidation in untracked code Ævar Arnfjörð Bjarmason
2018-01-03 20:49 ` [PATCH v2 4/5] update-index doc: note a fixed bug in the untracked cache Ævar Arnfjörð Bjarmason
2018-01-03 20:49 ` [PATCH v2 5/5] dir.c: stop ignoring opendir() error in open_cached_dir() Ævar Arnfjörð Bjarmason
2018-01-07 12:44 ` Duy Nguyen
2017-12-28 19:50 ` [PATCH] dir.c: avoid stat() in valid_cached_dir() Ævar Arnfjörð Bjarmason
2018-01-02 0:02 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq608qllcd.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox