From: Junio C Hamano <gitster@pobox•com>
To: Kaartic Sivaraam <kaartic.sivaraam@gmail•com>
Cc: Git mailing list <git@vger•kernel.org>
Subject: Re: [PATCH] rebase: rebasing can also be done when HEAD is detached
Date: Wed, 22 Nov 2017 11:13:31 +0900 [thread overview]
Message-ID: <xmqq60a3xdpw.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171121152533.3793-1-kaartic.sivaraam@gmail.com> (Kaartic Sivaraam's message of "Tue, 21 Nov 2017 20:55:33 +0530")
Kaartic Sivaraam <kaartic.sivaraam@gmail•com> writes:
> In a repository when attempting to rebase when the HEAD is detached
> and it is already up to date with upstream (so there's nothing to do),
> the following message is shown
>
> Current branch HEAD is up to date.
>
> which is clearly wrong as HEAD is not a branch.
>
> Handle the special case of HEAD correctly to give a more precise
> error message.
>
> Signed-off-by: Kaartic Sivaraam <kaartic.sivaraam@gmail•com>
> ---
> In this patch, I basically assumed that there would be no
> branch named "HEAD".
Perhaps time to learn "git symbolic-ref HEAD" and use it instead of
depending on the name?
next prev parent reply other threads:[~2017-11-22 2:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 15:25 [PATCH] rebase: rebasing can also be done when HEAD is detached Kaartic Sivaraam
2017-11-22 2:13 ` Junio C Hamano [this message]
2017-11-27 17:21 ` [PATCH v2 0/3] rebase: give precise error message Kaartic Sivaraam
2017-11-27 17:21 ` [PATCH v2 1/3] rebase: use a more appropriate variable name Kaartic Sivaraam
2017-11-27 17:21 ` [PATCH v2 2/3] rebase: distinguish user input by quoting it Kaartic Sivaraam
2017-11-27 17:21 ` [PATCH v2 3/3] rebase: rebasing can also be done when HEAD is detached Kaartic Sivaraam
2017-11-28 2:31 ` Junio C Hamano
2017-11-28 16:15 ` Kaartic Sivaraam
2017-12-01 6:09 ` [PATCH v3 " Kaartic Sivaraam
2017-11-28 2:25 ` [PATCH v2 0/3] rebase: give precise error message Junio C Hamano
2017-11-28 14:04 ` Kaartic Sivaraam
2017-11-29 0:10 ` Junio C Hamano
2017-11-29 3:11 ` Kaartic Sivaraam
2017-11-29 6:47 ` Junio C Hamano
2017-12-16 9:03 ` [PATCH v5 0/3] rebase: give precise error messages Kaartic Sivaraam
2017-12-16 9:03 ` [PATCH v5 1/3] rebase: consistently use branch_name variable Kaartic Sivaraam
2017-12-16 9:03 ` [PATCH v5 2/3] rebase: distinguish user input by quoting it Kaartic Sivaraam
2017-12-16 9:03 ` [PATCH v5 3/3] rebase: rebasing can also be done when HEAD is detached Kaartic Sivaraam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq60a3xdpw.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=kaartic.sivaraam@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox