From: Junio C Hamano <gitster@pobox•com>
To: Emily Xie <emilyxxie@gmail•com>
Cc: git@vger•kernel.org, David Turner <novalis@novalis•org>
Subject: Re: [PATCH] pathspec: die on empty strings as pathspec
Date: Thu, 22 Jun 2017 21:46:21 -0700 [thread overview]
Message-ID: <xmqq60fngvky.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqefubgxa3.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Thu, 22 Jun 2017 21:09:40 -0700")
Junio C Hamano <gitster@pobox•com> writes:
> Emily Xie <emilyxxie@gmail•com> writes:
>
>> I ran the tests and none of them failed.
>
> This is not about a test you touched, but applied to or merged to
> any of the recent integration branches (like 'master' or 'maint')
>
> $ make
> $ cd t
> $ GIT_TEST_LONG=YesPlease sh ./t0027-*.sh
>
> fails at the very beginning. I do not know if 0027 is the only one
> that triggers this failure, though.
t0027 should pass with this, I think.
I am not sure if we even want the dot there, but at least that is
what the original author of the test intended to do when s/he
decided to pass an empty string as the pathspec.
t/t0027-auto-crlf.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0027-auto-crlf.sh b/t/t0027-auto-crlf.sh
index 93725895a4..e41c9b3bb2 100755
--- a/t/t0027-auto-crlf.sh
+++ b/t/t0027-auto-crlf.sh
@@ -322,7 +322,7 @@ test_expect_success 'setup master' '
echo >.gitattributes &&
git checkout -b master &&
git add .gitattributes &&
- git commit -m "add .gitattributes" "" &&
+ git commit -m "add .gitattributes" . &&
printf "\$Id: 0000000000000000000000000000000000000000 \$\nLINEONE\nLINETWO\nLINETHREE" >LF &&
printf "\$Id: 0000000000000000000000000000000000000000 \$\r\nLINEONE\r\nLINETWO\r\nLINETHREE" >CRLF &&
printf "\$Id: 0000000000000000000000000000000000000000 \$\nLINEONE\r\nLINETWO\nLINETHREE" >CRLF_mix_LF &&
next prev parent reply other threads:[~2017-06-23 4:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 3:33 [PATCH] pathspec: die on empty strings as pathspec Emily Xie
2017-06-09 16:28 ` Junio C Hamano
2017-06-10 6:21 ` Jeff King
2017-06-10 11:03 ` Junio C Hamano
2017-06-09 16:50 ` Brandon Williams
2017-06-10 5:54 ` Junio C Hamano
2017-06-23 2:34 ` Emily Xie
2017-06-23 4:09 ` Junio C Hamano
2017-06-23 4:46 ` Junio C Hamano [this message]
2017-06-23 18:04 ` Junio C Hamano
2017-06-23 20:52 ` Torsten Bögershausen
2017-06-23 20:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq60fngvky.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=emilyxxie@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=novalis@novalis$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox