From: Junio C Hamano <gitster@pobox•com>
To: Michael J Gruber <git@drmicha•warpmail.net>
Cc: git@vger•kernel.org, Jeff King <peff@peff•net>,
ZhenTian <loooseleaves@gmail•com>
Subject: Re: [PATCHv3] gpg-interface: check gpg signature creation status
Date: Tue, 14 Jun 2016 11:13:54 -0700 [thread overview]
Message-ID: <xmqq60tbaba5.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <8e08b63b58302b6e7fe91f0dfb5b476781bfd37d.1465915311.git.git@drmicha.warpmail.net> (Michael J. Gruber's message of "Tue, 14 Jun 2016 16:44:18 +0200")
Michael J Gruber <git@drmicha•warpmail.net> writes:
> bottom = signature->len;
> - len = strbuf_read(signature, gpg.out, 1024);
> + strbuf_read(signature, gpg.out, 1024);
> + strbuf_read(&err, gpg.err, 0);
Hmmmm, isn't this asking for a deadlock? When GPG spews more than
what would fit in a pipe buffer to its standard error (hence gets
blocked), its standard output may not complete, and the we would get
stuck by attempting to read from gpg.out, failing to reach the other
strbuf_read() that would unblock GPG by reading from gpg.err?
next prev parent reply other threads:[~2016-06-14 18:14 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 7:50 I lost my commit signature ZhenTian
2016-06-14 7:58 ` Jeff King
2016-06-14 8:09 ` ZhenTian
2016-06-14 8:18 ` Jeff King
2016-06-14 8:39 ` ZhenTian
2016-06-14 9:41 ` Jeff King
2016-06-14 9:56 ` ZhenTian
2016-06-14 10:57 ` Michael J Gruber
2016-06-14 11:11 ` [PATCH] gpg-interface: check gpg signature for correct header Michael J Gruber
2016-06-14 11:20 ` Jeff King
2016-06-14 11:34 ` Michael J Gruber
2016-06-14 11:58 ` Michael J Gruber
2016-06-14 12:05 ` [PATCHv2] " Michael J Gruber
2016-06-14 14:44 ` [PATCHv3] gpg-interface: check gpg signature creation status Michael J Gruber
2016-06-14 18:13 ` Junio C Hamano [this message]
2016-06-14 21:50 ` Jeff King
2016-06-14 22:26 ` Jeff King
2016-06-14 23:47 ` Junio C Hamano
2016-06-15 0:56 ` Jeff King
2016-06-15 7:17 ` Michael J Gruber
2016-06-16 9:25 ` Jeff King
2016-06-16 11:30 ` Michael J Gruber
2016-06-15 3:28 ` Jeff King
2016-06-15 4:27 ` I lost my commit signature ZhenTian
2016-06-15 4:34 ` Jeff King
2016-06-15 7:07 ` Michael J Gruber
2016-06-15 10:36 ` ZhenTian
2016-06-16 7:34 ` Jeff King
2016-06-16 17:06 ` Junio C Hamano
2016-06-17 8:18 ` Michael J Gruber
2016-06-17 16:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq60tbaba5.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@drmicha$(echo .)warpmail.net \
--cc=git@vger$(echo .)kernel.org \
--cc=loooseleaves@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox